https://bugzilla.redhat.com/show_bug.cgi?id=1766874
Bug ID: 1766874 Summary: Review Request: jaero - A SatCom ACARS demodulator and decoder for the Aero standard Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: vascom2@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/RussianFedora/jaero/master/jaero.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4983/38654983/jaero-1.0.4.11-...
Description: JAERO is a program that demodulates and decodes Classic Aero ACARS (Aircraft Communications Addressing and Reporting System) messages sent from satellites to aeroplanes (SatCom ACARS), commonly used when planes are beyond VHF range.
Demodulation is performed using the soundcard.
Such signals are typically around 1.5Ghz and can be received with a low-gain antenna that can be home-brewed in conjunction with an RTL-SDR dongle.
https://bugzilla.redhat.com/show_bug.cgi?id=1766874
--- Comment #1 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://raw.githubusercontent.com/RussianFedora/jaero/master/jaero.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5473/38655473/jaero-1.0.4.11-...
License corrected.
https://bugzilla.redhat.com/show_bug.cgi?id=1766874
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vitaly@easycoding.org Assignee|nobody@fedoraproject.org |vitaly@easycoding.org Flags| |fedora-review?
--- Comment #2 from Vitaly Zaitsev vitaly@easycoding.org ---
Requires: unzip
1. Add %{?_isa}.
BuildRequires: kiss-fft-static
2. kiss-fft-devel
sed -i '/kiss_fft130/kiss_fft/d' JAERO/JAERO.pro
3. Please replace multiple sed calls with a single one.
cd JAERO/build
4. I think it will be better to use pushd JAERO/build ... popd instead.
5, Please add AppData metafile and send it to upstream.
6. Add comments to used in project patches.
https://bugzilla.redhat.com/show_bug.cgi?id=1766874
--- Comment #3 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://raw.githubusercontent.com/RussianFedora/jaero/master/jaero.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8574/38678574/jaero-1.0.4.11-...
1. Added %{?_isa} to unzip.
2. Gudelines say that need BR: ...-static https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static... And because -devel provides static I set only one of them.
3. Multiple sed replaced.
4. Used pushd/popd.
5. I don't have AppData.
6. Comments to patches added.
https://bugzilla.redhat.com/show_bug.cgi?id=1766874
--- Comment #4 from Vitaly Zaitsev vitaly@easycoding.org --- The license is MIT and LGPLv2.1:
./JAERO/gui_classes/console.cpp: LGPL (v2.1 or v3) ./JAERO/gui_classes/console.h: LGPL (v2.1 or v3)
mkdir JAERO/build
Can be moved to %prep.
I don't have AppData.
You should add it manually and send pull request to upstream.
https://bugzilla.redhat.com/show_bug.cgi?id=1766874
--- Comment #5 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://raw.githubusercontent.com/RussianFedora/jaero/master/jaero.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3088/38683088/jaero-1.0.4.11-...
AppData added.
https://bugzilla.redhat.com/show_bug.cgi?id=1766874
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Vitaly Zaitsev vitaly@easycoding.org --- LGTM now. Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1766874
--- Comment #7 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/jaero
https://bugzilla.redhat.com/show_bug.cgi?id=1766874
Vasiliy Glazov vascom2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2019-10-31 14:09:26
package-review@lists.fedoraproject.org