https://bugzilla.redhat.com/show_bug.cgi?id=1402656
Bug ID: 1402656 Summary: Review Request: bdsync - Remote sync for block devices Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: error@ioerror.us QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://error.fedorapeople.org/bdsync.spec SRPM URL: https://error.fedorapeople.org/bdsync-0.10-2.fc26.src.rpm
Description: Bdsync can be used to synchronize block devices over a network. It generates a "binary patchfile" in an efficient way by comparing MD5 checksums of 32k blocks of the local block device LOCDEV and the remote block device REMDEV.
This binary patchfile can be sent to the remote machine and applied to its block device DSTDEV, after which the local blockdev LOCDEV and the remote block device REMDEV are synchronized.
bdsync was built to do the only thing rsync isn't able to do: synchronize block devices.
Fedora Account System Username: error
Note: rpmlint produces an error: bdsync.x86_64: E: incorrect-fsf-address /usr/share/licenses/bdsync/COPYING This has been reported upstream as https://github.com/TargetHolding/bdsync/pull/15
https://bugzilla.redhat.com/show_bug.cgi?id=1402656
Sachidananda Urs surs@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |surs@redhat.com
--- Comment #1 from Sachidananda Urs surs@redhat.com --- This is an unofficial review of the package:
I see these warnings when I run rpmlint:
bdsync.src: W: no-url-tag
Can you please add an URL tag?
bdsync.x86_64: E: incorrect-fsf-address /usr/share/licenses/bdsync/COPYING
You might have put the address wrong for the above.
And under license, can you mention GPLv2 or GPLv3 instead of just GPL.
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overvi...
In %install, removing buildroot is optional and should be removed We don't need %clean section anymore. ref: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
https://bugzilla.redhat.com/show_bug.cgi?id=1402656
--- Comment #2 from Michael Hampton error@ioerror.us --- Very strange, the files I had locally did not match what was on fedorapeople.org. I've uploaded fresh copies.
(In reply to Sachidananda Urs from comment #1)
I see these warnings when I run rpmlint:
bdsync.src: W: no-url-tag
Can you please add an URL tag?
This URL tag is already present. It was missing from the old copy of the spec file for some reason.
bdsync.x86_64: E: incorrect-fsf-address /usr/share/licenses/bdsync/COPYING
You might have put the address wrong for the above.
As I already mentioned, I reported this problem upstream.
And under license, can you mention GPLv2 or GPLv3 instead of just GPL.
The spec file lists the License: as GPLv2, which is what upstream says.
In %install, removing buildroot is optional and should be removed We don't need %clean section anymore. ref: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
No such directives are in the spec file.
https://bugzilla.redhat.com/show_bug.cgi?id=1402656
Rolf Fokkens rolf@rolffokkens.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rolf@rolffokkens.nl
--- Comment #3 from Rolf Fokkens rolf@rolffokkens.nl --- There's a new 0.10.1 release, which includes the COPYING fixes.
package-review@lists.fedoraproject.org