https://bugzilla.redhat.com/show_bug.cgi?id=1310294
--- Comment #16 from Rex Dieter <rdieter(a)math.unl.edu> ---
Looks good, all the blocker items mentioned previously were addressed.
Remaining items to consider:
5. SHOULD document why these compiler flags are needed in a .spec comment
CFLAGS="-DSQLITE_HAS_CODEC -DSQLITE_TEMP_STORE=2"
LDFLAGS="-lcrypto"
...
I'd suggest a comment:
# recommended in README.md ## Compiling section
7a. MUST use %%license tag, instead of:
%doc LICENSE README.md
use
%doc README.md
%license LICENSE
7b. SHOULD, since main pkg already includes README.md and LICENSE, no need to
include in -devel and -tcl subpkg's too, please remove them.
8. (since you're already using %{make_install}), SHOULD use convenience macro
%{make_build}
instead of
make %{?_smp_mflags}
use
%{make_build}
naming: ok
sources: ok
26be3c23220192fb42e1d60f8c90ac69 v3.3.1.tar.gz
macros: ok
scriptlets: ok
licensing: NOT ok
9. MUST use
License: BSD
to match recommendation on
https://fedoraproject.org/wiki/Licensing
10a. SHOULD consider using build option:
--disable-tcl
and avoid the hassle of the -tcl subpkg, unless you specifically are willing to
support this.
10b. MUST: If you choose to keep -tcl subpkg, then must add a versioned
dependency to main pkg:
Requires: %{name}%{?_isa} = %{version}-%{release}
11. MUST remove
%define _unpackaged_files_terminate_build 0
there are better ways of fixing unpackaged files than this hack, for example,
adding this after %{make_install}:
rm -fv %{buildroot}%{_libdir}/lib*.la
12. MUST fix rpath issues, doing a local build, I get:
ERROR 0001: file '/usr/share/tcl8.6/sqlite3/libtclsqlite3.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR 0001: file '/usr/bin/sqlcipher' contains a standard rpath
'/usr/lib64'
in [/usr/lib64]
per
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelin...
adding after %configure, this helps:
13. SHOULD remove deprecated items/tags from .spec, including:
(from %install section):
rm -rf $RPM_BUILD_ROOT
Please fix all MUST (blocker) items, and I will approve this package review.
Consider addressing SHOULD (optional) items too, and you'll be extra awesome.
If it helps, here's a copy of
https://rdieter.fedorapeople.org/rpms/sqlcipher.spec
that implements all the suggested fixes (I think).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component