Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=887913
--- Comment #9 from Petr Pisar <ppisar(a)redhat.com> ---
Spec file changes:
--- perl-Math-Clipper.spec.old 2013-01-02 10:59:45.371000000 +0100
+++ perl-Math-Clipper.spec 2013-01-08 10:09:41.174000000 +0100
@@ -1,23 +1,24 @@
Name: perl-Math-Clipper
Version: 1.16
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: Perl wrapper around Clipper library
License: Boost
Group: Development/Libraries
URL:
http://search.cpan.org/dist/Math-Clipper/
Source0:
http://www.cpan.org/authors/id/A/AA/AAR/Math-Clipper-%{version}.tar.gz
Patch0: %{name}-1.16-1.no-c-sources.patch
-BuildRequires: perl(ExtUtils::Typemaps::Default) >= 0.05
-BuildRequires: perl(ExtUtils::XSpp) >= 0.16
-BuildRequires: perl(Module::Build)
-BuildRequires: perl(Module::Build::WithXSpp)
-BuildRequires: perl(Test::More)
-BuildRequires: perl(Test::Deep)
-BuildRequires: perl(File::Spec)
BuildRequires: perl(Carp)
BuildRequires: perl(Config)
+BuildRequires: perl(constant)
BuildRequires: perl(Exporter)
-BuildRequires: polyclipping-devel
+BuildRequires: perl(ExtUtils::Typemaps::Default) >= 0.05
+BuildRequires: perl(File::Spec)
+BuildRequires: perl(Module::Build)
+BuildRequires: perl(Module::Build::WithXSpp) >= 0.10
+BuildRequires: perl(Test::Deep)
+BuildRequires: perl(Test::More)
+BuildRequires: perl(XSLoader)
+BuildRequires: polyclipping-devel >= 4.10
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
%{?perl_default_filter} # Filters (not)shared c libs
@@ -45,12 +46,19 @@
./Build test
%files
-%doc Changes META.json xsp
+%doc Changes
%{perl_vendorarch}/auto/*
%{perl_vendorarch}/Math*
%{_mandir}/man3/*
%changelog
+* Thu Jan 03 2013 Miro Hrončok <miro(a)hroncok.cz> - 1.16-2
+- Removed META.json and xsp from doc
+- Specified version for polyclipping-devel BR
+- Specified version for perl(Module::Build::WithXSpp) BR
+- Removed perl(ExtUtils::XSpp) BR
+- Added BRs perl(XSLoader) and perl(constant)
+
* Fri Dec 28 2012 Miro Hrončok <miro(a)hroncok.cz> - 1.16-1
- New version
- Removed boundled C clipper and using the distribution one
TODO: Do not package META.json and xsp subtree. These are not useful
for users.
-%doc Changes META.json xsp
+%doc Changes
Ok.
TODO: Specify version for perl(Module::Build::WithXSpp) build-require
`>= 0.10' (META.yml:12).
TODO: In my opinion `perl(ExtUtils::XSpp)' is not direct
dependency of this package, so it shouldn't be build-required.
-BuildRequires:
perl(Module::Build::WithXSpp)
+BuildRequires: perl(Module::Build::WithXSpp) >= 0.10
Ok.
TODO: Build-require `perl(XSLoader)' for running tests
(lib/Math/Clipper.pm:14).
+BuildRequires: perl(XSLoader)
Ok.
TODO: Build-require `perl(constant)' for running tests
(t/002basic.t:6).
+BuildRequires: perl(constant)
Ok.
FIX: This package build-requires Module::Build::WithXSpp (bug
#876405) and ExtUtils::Typemaps::Default (bug #876399) which are not yet in Fedora. I
added proper bug dependencies and I postponed this review until they get into Fedora.
Ok.
TODO: You can replace %__perl macro with plain perl.
All tests pass. Ok.
$ rpmlint perl-Math-Clipper.spec ../SRPMS/perl-Math-Clipper-1.16-2.fc19.src.rpm
../RPMS/x86_64/perl-Math-Clipper-1.16-2.fc19.x86_64.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/x86_64/perl-Math-Clipper-1.16-2.fc19.x86_64.rpm
drwxr-xr-x 2 root root 0 Jan 8 10:24
/usr/lib64/perl5/vendor_perl/Math
-rw-r--r-- 1 root root 24913 Jan 8 10:24
/usr/lib64/perl5/vendor_perl/Math/Clipper.pm
drwxr-xr-x 2 root root 0 Jan 8 10:24
/usr/lib64/perl5/vendor_perl/auto/Math
drwxr-xr-x 2 root root 0 Jan 8 10:24
/usr/lib64/perl5/vendor_perl/auto/Math/Clipper
-rwxr-xr-x 1 root root 36544 Jan 8 10:24
/usr/lib64/perl5/vendor_perl/auto/Math/Clipper/Clipper.so
drwxr-xr-x 2 root root 0 Jan 8 10:24
/usr/share/doc/perl-Math-Clipper-1.16
-rw-r--r-- 1 root root 3365 Dec 26 15:31
/usr/share/doc/perl-Math-Clipper-1.16/Changes
-rw-r--r-- 1 root root 8769 Jan 8 10:24
/usr/share/man/man3/Math::Clipper.3pm.gz
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/x86_64/perl-Math-Clipper-1.16-2.fc19.x86_64.rpm
|sort |uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libgcc_s.so.1()(64bit)
1 libgcc_s.so.1(GCC_3.0)(64bit)
1 libpolyclipping.so.4()(64bit)
1 libstdc++.so.6()(64bit)
1 libstdc++.so.6(CXXABI_1.3)(64bit)
1 libstdc++.so.6(GLIBCXX_3.4)(64bit)
1 perl >= 0:5.008
1 perl(Carp)
1 perl(Config)
1 perl(Exporter)
1 perl(:MODULE_COMPAT_5.16.2)
1 perl(strict)
1 perl(warnings)
1 perl(XSLoader)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 rtld(GNU_HASH)
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/x86_64/perl-Math-Clipper-1.16-2.fc19.x86_64.rpm
|sort |uniq -c
1 perl(Math::Clipper) = 1.16
1 perl-Math-Clipper = 1.16-2.fc19
1 perl-Math-Clipper(x86-64) = 1.16-2.fc19
Binary provides are Ok.
FIX: Package does not build in F19
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=4847703).
Math::Clipper::orientation: polygon is not an array reference at
t/011Int128Comparison.t line 30.
# Looks like your test exited with 255 before it could output anything.
t/011Int128Comparison.t ..
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/1 subtests
Test Summary Report
-------------------
t/011Int128Comparison.t (Wstat: 65280 Tests: 0 Failed: 0)
Non-zero exit status: 255
Parse errors: Bad plan. You planned 1 tests but ran 0.
Files=11, Tests=63, 1 wallclock secs ( 0.06 usr 0.02 sys + 0.45 cusr 0.07
csys = 0.60 CPU)
Result: FAIL
I think this is due to newer polyclipping-devel-5.0.2-1.fc19 library in
rawhide.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct all `FIX' issues, consider fixing `TODO' items, and provide new
spec file.
Resolution: Package NOT approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=6KTEIElD2h&a=cc_unsubscribe