https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Bug ID: 2119983 Summary: Review Request: c-icap - An implementation of an ICAP server Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: negativo17@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.10-4.fc36.src.rpm Description: C-icap is an implementation of an ICAP server. It can be used with HTTP proxies that support the ICAP protocol to implement content adaptation and filtering services. Most of the commercial HTTP proxies must support the ICAP protocol, the open source Squid 3.x proxy server supports it too. Fedora Account System Username: slaanesh
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? | |needinfo?(negativo17@gmail. | |com) Doc Type|--- |If docs needed, set a value CC| |jonathan@almalinux.org Assignee|nobody@fedoraproject.org |jonathan@almalinux.org
--- Comment #1 from Jonathan Wright jonathan@almalinux.org ---
Summary: An implementation of an ICAP server Name: c-icap
Generally speaking it's best to put the `Name` at the top of the file below only global macros/overrides. I'm not sure if there's documentation citing this so consider it a suggested best practice at minimum.
License: LGPLv2+
Licenses should be in SPDX format now. [1]
Source0: http://downloads.sourceforge.net/project/%%7Bname%7D/%%7Bname%7D/0.5.x/c_ica...
Personally I'd use GitHub for the source URL here, mainly due to the "0.5.x" part of the URL which will require updating in the future whereas a GH URL can use all variables.
https://github.com/c-icap/c-icap-server/archive/C_ICAP_%%7Bversion%7D/c_icap...
%doc AUTHORS COPYING README TODO
`COPYING` should not be under `%doc` but on its own line: `%license COPYING` [2]
%config(noreplace) %{_tmpfilesdir}/%{name}.conf
Config files cannot go in /usr. [3]
BuildRequires: libdb-devel
This package is deprecated so you cannot depend on it. [4]
%package perl Summary: The Perl handler for %{name} Requires: %{name} = %{version}-%{release}
Since this is an architecture-specific compiled lib you need to match the full version including arch. It's always better to overstate the version anyway. [5] ie:
Requires: %{name}%{?_isa} = %{version}-%{release}
Same for the ldap sub-package.
---
The old changelog from other folks is probably not needed. The %changelog section is really to show a package's history in Fedora to represent potential user-impacting changes so anything before it became a package isn't really relevant. [6]
1. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline... 2. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation 3. https://docs.fedoraproject.org/en-US/packaging- guidelines/#_configuration_files 4. https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packag... 5. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_p... 6. https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #2 from Simone Caronni negativo17@gmail.com --- Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.10-5.fc36.src.rpm
Thanks for the review!
I fixed everything except these:
(In reply to Jonathan Wright from comment #1)
Personally I'd use GitHub for the source URL here, mainly due to the "0.5.x" part of the URL which will require updating in the future whereas a GH URL can use all variables.
That would be my preference as well, but unfortunately the Github tags are not there for the c-icap-modules counterpart, so I would need to rely there anyway on the SF links. For consistency I've left the tarball URL pointing to SF as described in their release page.
BuildRequires: libdb-devel
This package is deprecated so you cannot depend on it. [4]
I know there can't be newer versions in Fedora/EPEL due to licensing reasons (hit the same with the bitcoin-core review, where I had to bundle it in the package), but the package is not deprecated: https://src.fedoraproject.org/rpms/libdb/tree/rawhide It's also in the base repositories of el7, 8 and 9, so still fully supported at the moment.
The old changelog from other folks is probably not needed. The %changelog section is really to show a package's history in Fedora to represent potential user-impacting changes so anything before it became a package isn't really relevant. [6]
I've left the versions intact as this should update the packages at https://copr.fedorainfracloud.org/coprs/frankcrawford/c-icap/, I will maintain this package along the owner of that COPR repository.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #3 from Jonathan Wright jonathan@almalinux.org ---
BuildRequires: libdb-devel
This package is deprecated so you cannot depend on it. [4]
I know there can't be newer versions in Fedora/EPEL due to licensing reasons (hit the same with the bitcoin-core review, where I had to bundle it in the package), but the package is not deprecated: https://src.fedoraproject.org/rpms/libdb/tree/rawhide It's also in the base repositories of el7, 8 and 9, so still fully supported at the moment.
The package is deprecated even though it's still in repos and from my understanding of packaging guidelines cannot be used for new packages.
Specifically this quote from the guidelines:
In order to prevent new packages from depending on such a package, it can be marked as deprecated.
https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packag... explains that a virtual provides is added for deprecated which is present in libdb at https://src.fedoraproject.org/rpms/libdb/blob/rawhide/f/libdb.spec#_72
https://fedoraproject.org/wiki/Changes/Libdb_deprecated has a bit more information about the deprecation and https://pagure.io/fesco/issue/2379 confirming that it is indeed, deprecated.
This is my first review/experience with a deprecated package but the guidelines seem quite clear here. My recommendation is to email the devel list and seek further guidance. I'm happy to reply to a thread on devel and seek a double check on my interpretation of the guidelines here if you start said thread.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(negativo17@gmail. | |com) |
--- Comment #4 from Simone Caronni negativo17@gmail.com --- Ok thanks, this is all new to me, I missed it completely. It seems no progress has been made since the Fedora 33 page, including the "tool" to migrate in Fedora 35.
I will look what's the impact on the software just disabling the Berkeley DB.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #5 from Simone Caronni negativo17@gmail.com --- Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.10-6.fc36.src.rpm
Actually it was pretty easy, the DB support is only for supporting a list of local users which is not even recommended by the authors. In our production setup we've not even looked at it.
I've disabled the DB support in the build and integrated the LDAP plugin, it adds only a small dependency.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #6 from Simone Caronni negativo17@gmail.com --- btw, my time is limited, but if you need reviews in return for your effort please let me know. Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(negativo17@gmail. | |com)
--- Comment #7 from Jonathan Wright jonathan@almalinux.org --- The latest version you linked will not compile. I tried rawhide and f36.
``` make[2]: Leaving directory '/builddir/build/BUILD/c_icap-0.5.10/modules' /usr/bin/ld: cannot find -ldb collect2: error: ld returned 1 exit status make[2]: *** [Makefile:562: perl_handler.la] Error 1 ```
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(negativo17@gmail. | |com) |
--- Comment #8 from Simone Caronni negativo17@gmail.com --- Sigh. I did not clean the buildroot before attempting to disable it, it's disabled for its specific module and not linked anywhere, but ldb is being pulled in for the perl module because perl itself links with it:
https://src.fedoraproject.org/rpms/perl/blob/rawhide/f/perl.spec#_194
So much for deprecated. Looking for a possible solution.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #9 from Simone Caronni negativo17@gmail.com --- Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.10-6.fc36.src.rpm
I've bundled libdb 5.3.28 (last one with a valid license for Fedora) inside the package, like all packages with BDB needs are now doing (pretty pointless in my opinion).
I've added the necessary provide:
$ rpm -qp --provides c-icap-libs-0.5.10-6.fc36.x86_64.rpm | grep bundle bundled(libdb) = 5.3.28
Detailed change here: https://github.com/scaronni/c-icap/commit/070551ee4fdc9f88e8f7cfb1673827259b...
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #10 from Frank Crawford frank@crawford.emu.id.au --- Note, I've added it as a issue in the C-ICAP Github repo that it would be good to move away from BDB. Will see what comes from it.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #11 from Frank Crawford frank@crawford.emu.id.au --- (In reply to Frank Crawford from comment #10)
Note, I've added it as a issue in the C-ICAP Github repo that it would be good to move away from BDB. Will see what comes from it.
And the upstream developers are going to look at it. There comments were:
Lookup-tables based on lmdb and tdb can be easily implemented in c-icap. The lmdb can be used as bdb replacement for c-icap-modules/url_check/SquidGuard databases. The Tokyo Cabinet is GPL lisensed, a module which implements lookup-tables can be implemented in c-icap-modules package.
The first goal is to use lmdb instead of bdb.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #12 from Simone Caronni negativo17@gmail.com --- (In reply to Frank Crawford from comment #11)
(In reply to Frank Crawford from comment #10)
Note, I've added it as a issue in the C-ICAP Github repo that it would be good to move away from BDB. Will see what comes from it.
And the upstream developers are going to look at it. There comments were:
Lookup-tables based on lmdb and tdb can be easily implemented in c-icap. The lmdb can be used as bdb replacement forc-icap-modules/url_check/SquidGuard databases. The Tokyo Cabinet is GPL lisensed, a module which implements lookup-tables can be implemented in c-icap-modules package.
The first goal is to use lmdb instead of bdb.
Thanks Frank! Did they commit on any ETA?
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #13 from Frank Crawford frank@crawford.emu.id.au --- Unfortunately, no, just soon, but I don't know how long that may be for them.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jonathan@almalinu | |x.org) | |needinfo?(jonathan@almalinu | |x.org)
--- Comment #14 from Simone Caronni negativo17@gmail.com --- @jonathan@almalinux.org I'll be happy to switch away from bdb as soon as it's available but in the meanwhile we can proceed with the review.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jonathan@almalinu | |x.org)
--- Comment #15 from Simone Caronni negativo17@gmail.com --- @jonathan@almalinux.org any chance we can proceed with the review? It has now been 3 weeks since I posted the updated SPEC file. I have 3 other reviews depending on this package.
Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford frank@crawford.emu.id.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |frank@crawford.emu.id.au Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford frank@crawford.emu.id.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(negativo17@gmail. | |com)
--- Comment #17 from Frank Crawford frank@crawford.emu.id.au --- @negativo17@gmail.com Okay, I've formally taken this on now. I'll get something done on it in the next week.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford frank@crawford.emu.id.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(negativo17@gmail. | |com)
--- Comment #18 from Frank Crawford frank@crawford.emu.id.au --- @negativo17@gmail.com Just starting to look at the review, and most looks good, although I have a lot of items to tick off.
Looking at the licensing, and while it isn't a big issue, the basic licensing is LGPL2.1 or later, and Sleepycat (c.f. BSD 4-Clause), plus a little GPL2.0 or later and BSD 3-Clause.
You currently have BSD-3-Clause and LGPL-2.0-or-later and Sleepycat
From the c-icap repo, it only claims LGPL-2.1, but does have files listing LGPL-2.1-or-later and the odd file that is only GPL-2.0-or-later. From BDB it is "BSD and LGPLv2 and Sleepycat", which looks to be fore SPDX "Sleepycat and BSD-3-Clause and BSD-4-Clause" (I actually can't find any LGPLv2 files in BDB!).
So I think possibly the license entry should be: LGPL-2.1-or-later and GPL-2.0-or-later and (Sleepycat and BSD-3-Clause and BSD-4-Clause)
However, I'll leave you to consider what you want to do.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford frank@crawford.emu.id.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(negativo17@gmail. | |com) Status|NEW |ASSIGNED
--- Comment #19 from Frank Crawford frank@crawford.emu.id.au --- @negativo17@gmail.com Two items with the bundled Berkeley DB. Firstly, to include the bundled BDB library you also need an FPC exception.
However, secondly, it is likely you can get an exception to link against the system library, given upstream have agreed to provide additional suitable options, just that it isn't available yet (and that BDB will probably be around for a while).
You can apply for an exception at https://pagure.io/fesco
Please let me know what you plan to do.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@emailplus.org
--- Comment #20 from Benson Muite benson_muite@emailplus.org --- Based on the discussion https://github.com/c-icap/c-icap-server/issues/43 Maybe it is easier to make a pull request? It seems changes are needed in 2 files https://github.com/c-icap/c-icap-server/search?q=bdb
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #21 from Frank Crawford frank@crawford.emu.id.au --- (In reply to Benson Muite from comment #20)
Based on the discussion https://github.com/c-icap/c-icap-server/issues/43 Maybe it is easier to make a pull request? It seems changes are needed in 2 files https://github.com/c-icap/c-icap-server/search?q=bdb
Agreed, although do you have any suggestion on what actually needs updating? Also, it may be worth adding an additional option to differentiate it from bdb.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #22 from Benson Muite benson_muite@emailplus.org --- There are tests distributed with the code. Maybe some of these should be run in a %check section?
Using:
./configure --with-perl --with-openssl --with-zlib --with-bzlib --with-ldap --enable-ipv6 --enable-lib-compat --enable-large-files --without-bdb --prefix=$HOME/SomeLocation
Then checking $ ldd --unused perl_handler.so Unused direct dependencies: /lib64/libresolv.so.2 /lib64/libgdbm.so.6 /lib64/libdb-5.3.so /lib64/libm.so.6 /lib64/libcrypt.so.2 /lib64/libgdbm_compat.so.4 /lib64/libatomic.so.1
Indicates that libdb is linked but is not used.
In particular using $perl -MConfig -e 'print $Config{libs}' -lpthread -lresolv -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
one sees that Perl brings in libdb https://github.com/c-icap/c-icap-server/blob/master/configure.ac#L348 from https://src.fedoraproject.org/rpms/perl/blob/rawhide/f/perl.spec#_194
May also want to examine the Perl guidelines to add correct requires for the Perl subpackage: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_perl_requir...
An updated spec file is available at: https://download.copr.fedorainfracloud.org/results/fed500/c-icap/fedora-rawh... Corresponding srpm: https://download.copr.fedorainfracloud.org/results/fed500/c-icap/fedora-rawh...
Output of Fedora-Review: https://download.copr.fedorainfracloud.org/results/fed500/c-icap/fedora-rawh...
It seems logrotate should be required by the main package? There also seem to be further linking problems to resolve.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford frank@crawford.emu.id.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org)
--- Comment #23 from Frank Crawford frank@crawford.emu.id.au --- @benson_muite@emailplus.org Thanks for all your assistance here. Out of interest, do you want to do the full review? I'm more used to python, etc, than compiled code reviews. If you want to, I'm happy to pass it over, otherwise, if not, I'll just take on your comments to make sure they are covered.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #24 from Frank Crawford frank@crawford.emu.id.au --- I received a note back from the author on adding different DBs:
"Yes there is a small project which uses lmdb databases for both c-icap and c-icap-modules. Also there is a second small project to implement Tokyo Cabinet based modules as part of the c-icap-modules package. The two projects are in final stages only some cleanup required before published and merged to master branches."
And also, as there is a bit of a push to release a new version soon, I would expect they will end up in that release.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) |
--- Comment #25 from Benson Muite benson_muite@emailplus.org --- Will review the modules, but it is great for you to keep this review as you use this software and there are many packages waiting for a review.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #26 from Frank Crawford frank@crawford.emu.id.au --- No problem. Thanks for doing the modules.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #27 from Frank Crawford frank@crawford.emu.id.au --- For the Perl requirements, you may also want to read https://pagure.io/fesco/issue/2898 which is approved and upcoming.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(negativo17@gmail. | |com) | |needinfo?(negativo17@gmail. | |com) | |needinfo?(negativo17@gmail. | |com) |
--- Comment #28 from Simone Caronni negativo17@gmail.com --- Hi everyone, thanks for the inputs, I'm consolidating all the changes from the various comments.
(In reply to Benson Muite from comment #22)
An updated spec file is available at: https://download.copr.fedorainfracloud.org/results/fed500/c-icap/fedora- rawhide-x86_64/05188184-c-icap/c-icap.spec
@benson_muite@emailplus.org this drops completely BDB, I'm fine with that as we're not using it in our installation and we can add DB support later when one of the above mentioned projects come to life.
@frank@crawford.emu.id.au what's your take? Is it ok without BDB? I think most people would anyway use this package as a simple ICAP server for web integrations (proxies, etc.). We use it with the AVI WAF and Kubernetes integration (https://avinetworks.com/).
(In reply to Frank Crawford from comment #27)
For the Perl requirements, you may also want to read https://pagure.io/fesco/issue/2898 which is approved and upcoming.
Regarding this, I can see the change has happened for Fedora but it's missing the perl-generators-epel and consequently the updated guideline. I'll keep an eye on it and add it once it becomes live, so we can avoid having different SPEC files for different distributions.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #29 from Frank Crawford frank@crawford.emu.id.au --- Simone,
I'm fine with dropping BDB for now, especially to get it into the system. Once the new packages/modules for LMDB or equivalent is added upstream, it may be worth including a Fedora approved DB.
As for Perl requirements, it was really just an FYI.
One other thing about the new spec from Benson, he has logrotate as a BuildRequires. Shouldn't that just be a Requires?
Frank
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #30 from Simone Caronni negativo17@gmail.com --- (In reply to Frank Crawford from comment #29)
As for Perl requirements, it was really just an FYI.
Actually I discovered perl-generators is already available in EPEL as well, it's subpackage of .... and not a standalone package like in Fedora, that's why I did not find it.
One other thing about the new spec from Benson, he has logrotate as a BuildRequires. Shouldn't that just be a Requires?
Fixed as well.
Full diff of changes here: https://github.com/scaronni/c-icap/commit/73dcc1a64342e30986a609a33584124a6d...
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #31 from Simone Caronni negativo17@gmail.com --- Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.10-7.fc37.src.rpm
* Wed Jan 04 2023 Simone Caronni negativo17@gmail.com - 0.5.10-7 - Review fixes: drop bundled Berkeley DB and disable DB support, adjust Perl requirements, add tests, adjust licenses.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #32 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5199014 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-211...
Please make sure the package builds successfully at least for Fedora Rawhide.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #33 from Simone Caronni negativo17@gmail.com --- Ignore the message above, for some reason it did not find the src.rpm momentarily. Builds fine on epel7 and up.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #35 from Frank Crawford frank@crawford.emu.id.au --- @negativo17@gmail.com I've been through the full review process and found two items that I'd say are "Fail" but are also easily fixed.
Patches link to upstream bugs/comments/lists or are otherwise justified.
This really just needs a comment in the spec file.
Package should not use obsolete m4 macros
This one comes up from the automated tests in FedoraReview, and I think is easiest to fix by doing a PR for upstream.
There are also a couple of other rpmlint issues that I noted:
c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf
This is really just that while you install the tmpfile, it isn't invoked during the install, so the directory won't be invoked until the next reboot. There is a %tmpfiles_create macro for use in %post that should fix this.
c-icap-devel.x86_64: E: incorrect-fsf-address /usr/include/c_icap/txtTemplate.h
For this I'd log an issue upstream and leave it at that.
c-icap.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/sbin/c-icap
Again, I'd log it as an issue upstream and leave it at that.
For the other rpmlint errors, they are not relevant (non-standard-uid/gid and non-standard-dir-perm) or the dependencies are covered by other modules and I should be able to zap them in a .rpmlintrc file.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford frank@crawford.emu.id.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(negativo17@gmail. | |com)
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #36 from Frank Crawford frank@crawford.emu.id.au --- FYI, just got this from upstream:
Support for lmdb lookup tables exists in latest c-icap master branch. Also in latest c-icap-modules the url_check service can use, and by default uses, lmdb to implement squidguard like databases.
You can decide if you want to pick up these patches or wait for a new release, which I think is not far away.
Obviously it is new, so you may want to test it before pushing it to production.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #37 from Simone Caronni negativo17@gmail.com --- Sorry struggling a bit at work the past week. Will pick it up again tonight or tomorrow.
Thanks for the heads up on the changes in the next release.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #38 from Frank Crawford frank@crawford.emu.id.au --- Any update?
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(negativo17@gmail. | |com) |
--- Comment #39 from Simone Caronni negativo17@gmail.com --- Tomorrow morning, finally, I will be able to work on it. Emergencies at work pulled back.
Thanks for the patience.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jonathan@almalinu | |x.org) | |needinfo?(jonathan@almalinu | |x.org) |
--- Comment #40 from Simone Caronni negativo17@gmail.com --- Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.11-8.20230129git5b8fcd9.fc37.sr...
* Fri Feb 10 2023 Simone Caronni negativo17@gmail.com - 0.5.11-8.20230129git5b8fcd9 - Update to latest snapshot. - Enable LMDB.
Complete diff here: https://github.com/scaronni/c-icap/commit/bf5fe707de925d033cc2b68b4f00b46178...
Working on the comments at https://bugzilla.redhat.com/show_bug.cgi?id=2119983#c35. I tried to update it first as I wanted to check if it was a viable option.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #41 from Simone Caronni negativo17@gmail.com --- (In reply to Frank Crawford from comment #35)
Patches link to upstream bugs/comments/lists or are otherwise justified.
This really just needs a comment in the spec file.
Done.
Package should not use obsolete m4 macros
This one comes up from the automated tests in FedoraReview, and I think is easiest to fix by doing a PR for upstream.
c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf
This is really just that while you install the tmpfile, it isn't invoked during the install, so the directory won't be invoked until the next reboot. There is a %tmpfiles_create macro for use in %post that should fix this.
I've never encountered this macro, so after searching a bit I found that it was rejected 8 years ago (!) and it never appears in the current packaging guidelines: - https://pagure.io/packaging-committee/issue/439 - https://fedoraproject.org/wiki/Packaging:Tmpfiles.d - https://docs.fedoraproject.org/en-US/packaging-guidelines/Tmpfiles.d/
I see that in /usr/lib/rpm/macros.d/macros.systemd both %tmpfiles_create and %tmpfiles_create_package are there. Shall I include it anyway?
c-icap-devel.x86_64: E: incorrect-fsf-address /usr/include/c_icap/txtTemplate.h
For this I'd log an issue upstream and leave it at that.
c-icap.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/sbin/c-icap
Again, I'd log it as an issue upstream and leave it at that.
Done, there is also another: https://github.com/c-icap/c-icap-server/issues/49
Same URL as in comment above, I force pushed as the changes were minimal. New diff: https://github.com/scaronni/c-icap/commit/010152d351137bbf20996f9a0933d3b668...
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #42 from Simone Caronni negativo17@gmail.com --- I really wish we had some formatting options and an edit button :/
Checking the m4 macros.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #43 from Frank Crawford frank@crawford.emu.id.au --- Thanks for that.
I'll have a look around about what others do for the tmpfile issue, but otherwise, I think we should be able to knock this over this week sometime.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #44 from Simone Caronni negativo17@gmail.com --- I've done some testing with the deprecated configure macros, but even autoupdate + some manual changes to configure.ac does not meet my expectations, I need someone a bit more knowledgeable on autotools than me.
I've removed such changes, here is a small refresh:
Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.11-8.20230129git5b8fcd9.fc37.sr...
* Fri Feb 10 2023 Simone Caronni <negativo17> - 0.5.11-8.20230129git5b8fcd9 - Update to latest snapshot. - Enable LMDB.
https://github.com/scaronni/c-icap/commit/274f2374df03ec3124ed5f6bb153b9b42e...
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #45 from Simone Caronni negativo17@gmail.com --- I'll be away on holiday for 5 days starting tonight.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://%%7Bname%7D.sourceforge. | |net/
--- Comment #46 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5537259 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #47 from Simone Caronni negativo17@gmail.com --- (In reply to Jakub Kadlčík from comment #46)
Copr build: https://copr.fedorainfracloud.org/coprs/build/5537259 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora- review-2119983-c-icap/fedora-rawhide-x86_64/05537259-c-icap/builder-live.log. gz
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Failure for unrelated reasons:
DEBUG util.py:443: Errors during downloading metadata for repository 'fedora': DEBUG util.py:443: - Curl error (23): Failed writing received data to disk/application for https://d2lzkl7pfhq30w.cloudfront.net/pub/fedora/linux/development/rawhide/E... [Failure writing output to destination] DEBUG util.py:443: Error: Failed to download metadata for repo 'fedora': Yum repo downloading error: Downloading error(s): repodata/9936275d19d035a9da56961c088c5dc76946bb174aba4ccdd734cb5739a315f1-primary.xml.zck - Download failed: Curl error (23): Failed writing received data to disk/application for https://d2lzkl7pfhq30w.cloudfront.net/pub/fedora/linux/development/rawhide/E... [Failure writing output to destination]
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #48 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5537357 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #49 from Frank Crawford frank@crawford.emu.id.au --- Ahh, for this issue
c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf
It looks like the standard fix would be to add into the %install section
install -d -m 0755 %{buildroot}/run/%{name}/
and into the %files section
%dir /run/%{name}/
(probably with an attr to set the owner)
I should have read the full documentation better earlier.
As for the obsolete m4 macros, if they are too difficult at present, I'm willing to let them go, as long as we raise it upstream for a future fix. After all, it is a "should not", not a "must not" issue.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #50 from Simone Caronni negativo17@gmail.com --- (In reply to Frank Crawford from comment #49)
Ahh, for this issue
c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf
It looks like the standard fix would be to add into the %install section
install -d -m 0755 %{buildroot}/run/%{name}/
and into the %files section
%dir /run/%{name}/
(probably with an attr to set the owner)
I should have read the full documentation better earlier.
Tried both, it did not help. So the warning comes from rpmlint, which checks for the %tmpfiles_create macro. The %tmpfiles_create macros have been rejected for the policy, and the macros.systemd file reports that %tmpfiles_create has been replaced by %tmpfiles_create_package macro, which rpmlint would report as a failure anyway.
Regarding %dir /run/%{name}/, I was already setting it as %ghost /run/%{name}/. Both are fine, but I changed it back to %dir to follow the guidelines.
As for the obsolete m4 macros, if they are too difficult at present, I'm willing to let them go, as long as we raise it upstream for a future fix. After all, it is a "should not", not a "must not" issue.
I will open a bug for this as well, all the other rpmlint issues were fixed upstream after reporting them.
Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.11-9.20230220gitc5f2103.fc37.sr...
* Fri Feb 24 2023 Simone Caronni negativo17@gmail.com - 0.5.11-9.20230220gitc5f2103 - Update to latest snapshot.
https://github.com/scaronni/c-icap/commit/567581a424bd2d3308c18ad34fdf68a2cb...
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #51 from Simone Caronni negativo17@gmail.com --- (In reply to Simone Caronni from comment #50)
Tried both, it did not help. So the warning comes from rpmlint, which checks for the %tmpfiles_create macro. The %tmpfiles_create macros have been rejected for the policy, and the macros.systemd file reports that %tmpfiles_create has been replaced by %tmpfiles_create_package macro, which rpmlint would report as a failure anyway.
Forgot to mention that the macro is not there at all in older releases :/
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #52 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1946261 --> https://bugzilla.redhat.com/attachment.cgi?id=1946261&action=edit The .spec file difference from Copr build 5537357 to 5564920
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #53 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5564920 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #54 from Frank Crawford frank@crawford.emu.id.au --- Simone, it currently fails to build, as you left off the line
install -d -m 0755 %{buildroot}/run/%{name}/
Would you please fix and we will see how we go.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #55 from Frank Crawford frank@crawford.emu.id.au --- Looked at it all a bit closer and you also probably need to update the %files line to
%attr(0755,%{name},%{name}) %dir /run/%{name}/
That will match the actual creation in i-icap.tmpfiles.conf. It may also cause a minor conflict for the actual install, as the permissions may be wrong at that point, as the owner will be root:root, not c-icap:c-icap. Hmm, which is a bit tricky.
You are right that rpmlint has it wrong for the current Fedora packaging guidelines, and even for the new macro, but that just means we will need to suppress the actual complaint, as we will go with the packaging guidelines, not rpmlint.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #56 from Simone Caronni negativo17@gmail.com --- (In reply to Frank Crawford from comment #54)
Simone, it currently fails to build, as you left off the line
install -d -m 0755 %{buildroot}/run/%{name}/
Would you please fix and we will see how we go.
Right, because I switched from %ghost to %dir just before pushing the commit.
(In reply to Frank Crawford from comment #55)
Looked at it all a bit closer and you also probably need to update the %files line to
%attr(0755,%{name},%{name}) %dir /run/%{name}/
That will match the actual creation in i-icap.tmpfiles.conf. It may also cause a minor conflict for the actual install, as the permissions may be wrong at that point, as the owner will be root:root, not c-icap:c-icap. Hmm, which is a bit tricky.
That's not an issue, as the permissions are set in the RPM file when being assembled:
$ rpm -qpvl c-icap-0.5.11-9.20230220gitc5f2103.fc37.x86_64.rpm | grep run drwxr-xr-x 2 c-icap c-icap 0 Feb 26 11:09 /run/c-icap
Amended the same commit:
Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.11-9.20230220gitc5f2103.fc37.sr...
* Fri Feb 24 2023 Simone Caronni negativo17@gmail.com - 0.5.11-9.20230220gitc5f2103 - Update to latest snapshot. - Adjust tmpfiles creation.
https://github.com/scaronni/c-icap/commit/971969f0b7d9a5a4db48da7d678e0beaed...
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #57 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1946539 --> https://bugzilla.redhat.com/attachment.cgi?id=1946539&action=edit The .spec file difference from Copr build 5564920 to 5567273
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #58 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5567273 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford frank@crawford.emu.id.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(negativo17@gmail. | |com)
--- Comment #59 from Frank Crawford frank@crawford.emu.id.au --- @negativo17@gmail.com Fedora have now deprecated pcre-devel as of Fedora 38, and so we should get it converted to pcre2-devel! I have no idea how much trouble that is, but can you look at it.
From what I can tell, that should be the last issue.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #60 from Frank Crawford frank@crawford.emu.id.au --- Oh, looking through the rpmlint output attached to the review, there are a batch of little items that I see need fixing.
c-icap.x86_64: E: logrotate-user-writable-log-dir /var/log/c-icap c-icap:c-icap 0750
This needs an
su c-icap c-icap
in c-icap.logrotate
c-icap-libs.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libicapapi.so.0.0.1 SSL_CTX_set_cipher_list
This is trickier, but covered in https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ and effectively says the default be
PROFILE=SYSTEM
in the c-icap-conf but I'm not sure how that can be added into there.
And also:
c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/dnsbl_tables.so /lib64/libatomic.so.1
(and many more) may be covered by https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dep...
And finally:
c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/dnsbl_tables.so)
which I'm not sure, as that looks to be well define.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #61 from Frank Crawford frank@crawford.emu.id.au --- For the last one
c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/dnsbl_tables.so)
it may be that you require the libs package installed, so need to add into the main c-icap package a statement like
Requires: %{name}-libs%{?_isa} = %{version}-%{release}
What do you think?
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(negativo17@gmail. | |com) |
--- Comment #62 from Simone Caronni negativo17@gmail.com --- (In reply to Frank Crawford from comment #60)
Oh, looking through the rpmlint output attached to the review, there are a batch of little items that I see need fixing.
c-icap.x86_64: E: logrotate-user-writable-log-dir /var/log/c-icap c-icap:c-icap 0750
This needs an
su c-icap c-icap
in c-icap.logrotate
This is correct, the user should be able to write to it. Another option is to make it root:c-icap 0770, in this case the error stops but is not that different. Other packages in fedora do a mix of those.
c-icap-libs.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libicapapi.so.0.0.1 SSL_CTX_set_cipher_list
This is trickier, but covered in https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ and effectively says the default be
PROFILE=SYSTEM
in the c-icap-conf but I'm not sure how that can be added into there.
Yes, but this is a warning and it should be tackled upstream, i'll open a bug.
And also:
c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/dnsbl_tables.so /lib64/libatomic.so.1
(and many more) may be covered by https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib- dependency
And finally:
c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/dnsbl_tables.so)
which I'm not sure, as that looks to be well define.
These have gone with the latest rebase which also fixed the autotools deprecated macros (https://github.com/c-icap/c-icap-server/issues/50).
c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf c-icap.x86_64: W: non-standard-uid /run/c-icap c-icap c-icap.x86_64: W: non-standard-uid /var/log/c-icap c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap/c-icap.conf c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap/c-icap.magic c-icap c-icap.x86_64: W: non-standard-gid /run/c-icap c-icap c-icap.x86_64: W: non-standard-gid /var/log/c-icap c-icap c-icap.x86_64: E: non-standard-dir-perm /etc/c-icap 750 c-icap.x86_64: E: non-standard-dir-perm /var/log/c-icap 750 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.conf 640 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.magic 640 c-icap-perl.x86_64: W: no-documentation c-icap.x86_64: E: logrotate-user-writable-log-dir /var/log/c-icap c-icap:c-icap 0750 c-icap-libs.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libicapapi.so.0.0.1 SSL_CTX_set_cipher_list
(In reply to Frank Crawford from comment #59)
@negativo17@gmail.com Fedora have now deprecated pcre-devel as of Fedora 38, and so we should get it converted to pcre2-devel! I have no idea how much trouble that is, but can you look at it.
From what I can tell, that should be the last issue.
I've opened an issue on the project for this: https://github.com/c-icap/c-icap-server/issues/51
Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.11-10.20230319git2e36bb8.fc37.s...
* Fri Mar 31 2023 Simone Caronni negativo17@gmail.com - 0.5.11-10.20230319git2e36bb8 - Update to latest snapshot.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #63 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1954840 --> https://bugzilla.redhat.com/attachment.cgi?id=1954840&action=edit The .spec file difference from Copr build 5567273 to 5732104
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #64 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5732104 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #65 from Frank Crawford frank@crawford.emu.id.au --- For
c-icap.x86_64: E: logrotate-user-writable-log-dir /var/log/c-icap c-icap:c-icap 0750
I think the option to add
su c-icap c-icap
is really the cleaner fix, although the Fedora policy doesn't really seem to address it at all.
Unfortunately, the
c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/dnsbl_tables.so /lib64/libatomic.so.1
and
c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/dnsbl_tables.so)
are still there in the rpmlint output against dev and lib packages.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford frank@crawford.emu.id.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(negativo17@gmail. | |com)
--- Comment #66 from Frank Crawford frank@crawford.emu.id.au --- @negativo17@gmail.com Any updates for this review?
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(negativo17@gmail. | |com) |
--- Comment #67 from Simone Caronni negativo17@gmail.com --- Hi Frank, sorry for the delay. We're building a 2nd DC at work and this is killing all my possible free time. I'll update this and the dependend modules package (linked here) in the next days.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #68 from Frank Crawford frank@crawford.emu.id.au --- That is okay, I understand life gets in the way. Take as much time as you need.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #69 from Simone Caronni negativo17@gmail.com --- Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.11-11.20230403git1238524.fc38.s...
* Wed May 24 2023 Simone Caronni negativo17@gmail.com - 0.5.11-11.20230403git1238524 - Update to latest snapshot. - Switch to PCRE 2.
https://github.com/scaronni/c-icap/commit/278b1166b1c7e9896bf73ca7d1ffe8747e...
The rpmlint output looks good, I think we're good to go:
c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf c-icap.x86_64: W: non-standard-uid /run/c-icap c-icap c-icap.x86_64: W: non-standard-uid /var/log/c-icap c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap/c-icap.conf c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap/c-icap.magic c-icap c-icap.x86_64: W: non-standard-gid /run/c-icap c-icap c-icap.x86_64: W: non-standard-gid /var/log/c-icap c-icap c-icap.x86_64: E: non-standard-dir-perm /etc/c-icap 750 c-icap.x86_64: E: non-standard-dir-perm /var/log/c-icap 750 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.conf 640 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.magic 640 c-icap-perl.x86_64: W: no-documentation c-icap-libs.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libicapapi.so.0.0.1 SSL_CTX_set_cipher_list
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #70 from Simone Caronni negativo17@gmail.com --- What about renaming the package from "c-icap" to "c-icap-server" so it matches the repository name on Github?
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #71 from Simone Caronni negativo17@gmail.com --- Btw, easier to do the rename now while in review then later after the package is already in the repositories.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #72 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1966627 --> https://bugzilla.redhat.com/attachment.cgi?id=1966627&action=edit The .spec file difference from Copr build 5732104 to 5951852
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #73 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5951852 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #74 from Simone Caronni negativo17@gmail.com --- I've updated the modules and switched to LMDB at: https://bugzilla.redhat.com/show_bug.cgi?id=2119984
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #75 from Frank Crawford frank@crawford.emu.id.au --- (In reply to Simone Caronni from comment #70)
What about renaming the package from "c-icap" to "c-icap-server" so it matches the repository name on Github?
I don't have any problem with that, and it is easier now, so go for it.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #76 from Simone Caronni negativo17@gmail.com --- Nevermind, I changed my mind. I made an attempt and was not very convinced. Beside less substitution that can be used in the SPEC file, I think "c-icap" as the main package and "c-icap-<something>" as the subpackages and modules is more understandable at a glance.
Please use the last package at https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2119983#c69
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #77 from Frank Crawford frank@crawford.emu.id.au --- I'm going to approve this, as I don't think there is anything else we need to do.
However just to cover off the various rpmlint issues there are the reason to accept:
c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf
This is a warning, and no specific fix is given within the Fedora packaging documentation.
c-icap.x86_64: W: non-standard-uid /run/c-icap c-icap c-icap.x86_64: W: non-standard-uid /var/log/c-icap c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap c-icap ...
Warning, but package is running as a non-root user and these relate to this user, which is used appropriately.
c-icap.x86_64: E: non-standard-dir-perm /etc/c-icap 750 c-icap.x86_64: E: non-standard-dir-perm /var/log/c-icap 750 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.conf 640 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.magic 640
These permissions are required for the non-root user to access the directories and files.
c-icap-perl.x86_64: W: no-documentation
Warning, but none required for this module. Covered by the general documentation.
c-icap-libs.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libicapapi.so.0.0.1 SSL_CTX_set_cipher_list
Warning only. Raised upstream for possible future issue to address.
c-icap-perl.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/perl_handler.so /lib64/libresolv.so.2 ...
Warning only, but is required for dynamic linking.
c-icap-perl.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/perl_handler.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/perl_handler.so) ...
Warning only, but is defined in main program or other included c-icap libraries, and resolved during dynamic linking.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford frank@crawford.emu.id.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #78 from Frank Crawford frank@crawford.emu.id.au --- APPROVE. See review.
--- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package contains the mandatory BuildRequires and Requires:. Note: Explicit dependency on perl-devel is not allowed See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/
Package builds a perl library and links to perl in a compliant manner
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later", "*No copyright* GNU Lesser General Public License v2.1 or later", "*No copyright* Public domain", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]", "GNU General Public License v2.0 or later". 74 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/c-icap/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in c-icap [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in c-icap- devel , c-icap-libs [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros
Rpmlint ------- Checking: c-icap-0.5.11-11.20230403git1238524.fc39.x86_64.rpm c-icap-devel-0.5.11-11.20230403git1238524.fc39.x86_64.rpm c-icap-libs-0.5.11-11.20230403git1238524.fc39.x86_64.rpm c-icap-perl-0.5.11-11.20230403git1238524.fc39.x86_64.rpm c-icap-debuginfo-0.5.11-11.20230403git1238524.fc39.x86_64.rpm c-icap-debugsource-0.5.11-11.20230403git1238524.fc39.x86_64.rpm c-icap-0.5.11-11.20230403git1238524.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpaqzplatn')] checks: 31, packages: 7
c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf c-icap.x86_64: W: non-standard-uid /run/c-icap c-icap c-icap.x86_64: W: non-standard-uid /var/log/c-icap c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap/c-icap.conf c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap/c-icap.magic c-icap c-icap.x86_64: W: non-standard-gid /run/c-icap c-icap c-icap.x86_64: W: non-standard-gid /var/log/c-icap c-icap c-icap.x86_64: E: non-standard-dir-perm /etc/c-icap 750 c-icap.x86_64: E: non-standard-dir-perm /var/log/c-icap 750 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.conf 640 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.magic 640 c-icap-perl.x86_64: W: no-documentation c-icap-libs.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libicapapi.so.0.0.1 SSL_CTX_set_cipher_list 7 packages and 0 specfiles checked; 4 errors, 10 warnings, 4 badness; has taken 1.0 s
Rpmlint (debuginfo) ------------------- Checking: c-icap-perl-debuginfo-0.5.11-11.20230403git1238524.fc39.x86_64.rpm c-icap-libs-debuginfo-0.5.11-11.20230403git1238524.fc39.x86_64.rpm c-icap-debuginfo-0.5.11-11.20230403git1238524.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0tgs1f03')] checks: 31, packages: 3
3 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s
Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 8
c-icap-perl.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/perl_handler.so /lib64/libresolv.so.2 c-icap-perl.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/perl_handler.so /lib64/libgdbm.so.6 c-icap-perl.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/perl_handler.so /lib64/libm.so.6 c-icap-perl.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/perl_handler.so /lib64/libcrypt.so.2 c-icap-perl.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/perl_handler.so /lib64/libgdbm_compat.so.4 c-icap-perl.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/perl_handler.so /lib64/libatomic.so.1 c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/dnsbl_tables.so /lib64/libatomic.so.1 c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/ldap_module.so /lib64/libatomic.so.1 c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/lmdb_tables.so /lib64/libatomic.so.1 c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/shared_cache.so /lib64/libatomic.so.1 c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/srv_echo.so /lib64/libatomic.so.1 c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/srv_ex206.so /lib64/libatomic.so.1 c-icap.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/sys_logger.so /lib64/libatomic.so.1 c-icap-libs.x86_64: E: unused-direct-shlib-dependency /usr/lib64/libicapapi.so.0.0.1 /lib64/libbrotlicommon.so.1 c-icap-perl.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/perl_handler.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/perl_handler.so) c-icap-perl.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/perl_handler.so CI_DEBUG_STDOUT (/usr/lib64/c_icap/perl_handler.so) c-icap-perl.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/perl_handler.so __log_error (/usr/lib64/c_icap/perl_handler.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_cache_store_vector_val (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so CI_DEBUG_STDOUT (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_cache_read_vector_val (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so __log_error (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_str_ops (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_cfg_conf_table_allocate (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_cache_update (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_dyn_array_get_item (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_cfg_conf_table_push (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_cache_store_vector_size (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_stat_entry_register (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_vector_cast_to_voidvoid (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_vector_destroy (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_lookup_table_type_unregister (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_common_module_build (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_stat_uint64_inc (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_dyn_array_destroy (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_sockaddr_t_to_ip (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_str_vector_create (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_atol_ext (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_cache_search (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_cache_destroy (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_cache_build (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_str_vector_add (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_fill_sockaddr (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_parse_key_value_list (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_vector_cast_from_voidvoid (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/dnsbl_tables.so ci_lookup_table_type_register (/usr/lib64/c_icap/dnsbl_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_cache_store_vector_val (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so CI_DEBUG_STDOUT (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_cache_read_vector_val (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so __ci_debug_abort (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so __log_error (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_str_ops (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_cfg_disable (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_list_push (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_thread_cond_destroy (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_list_push_back (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_thread_mutex_init (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_list_iterator_next (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_cfg_conf_table_allocate (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_cache_update (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_dyn_array_get_item (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_cfg_conf_table_push (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_list_iterator_first (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_cache_store_vector_size (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_str_vector_add2 (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_buffer_realloc (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_str_trim (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_list_pop (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_stat_entry_register (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_buffer_free (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_vector_cast_to_voidvoid (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_vector_size (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_vector_destroy (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_lookup_table_type_unregister (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_common_module_build (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_dyn_array_destroy (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_thread_mutex_destroy (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_list_remove3 (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_str_vector_create (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_list_destroy (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_atol_ext (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_stat_memblock_get (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_cache_search (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_cache_destroy (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_cache_build (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_command_schedule (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_list_create (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_thread_cond_init (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_list_head (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_parse_key_value_list (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_vector_cast_from_voidvoid (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_command_register_action (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_buffer_alloc (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/ldap_module.so ci_lookup_table_type_register (/usr/lib64/c_icap/ldap_module.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so CI_DEBUG_STDOUT (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so __ci_debug_abort (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so __log_error (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_list_push (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_thread_mutex_init (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_cfg_conf_table_allocate (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_dyn_array_get_item (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_cfg_conf_table_push (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_flat_array_check (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_list_pop (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_stat_entry_register (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_buffer_free (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_lookup_table_type_unregister (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_common_module_build (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_stat_uint64_inc (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_list_destroy (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_list_first (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_atol_ext (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_flat_array_to_ppvoid (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_list_create (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_thread_cond_init (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_parse_key_value_list (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_command_register_action (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_buffer_alloc (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/lmdb_tables.so ci_lookup_table_type_register (/usr/lib64/c_icap/lmdb_tables.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so CI_DEBUG_STDOUT (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so __log_error (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_proc_mutex_destroy (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_cfg_conf_table_allocate (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_proc_mutex_init (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_hash_compute (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_cfg_conf_table_push (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_cache_type_register (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_stat_entry_register (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_shared_mem_attach (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_shared_mem_detach (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_common_module_build (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_stat_uint64_inc (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_shared_mem_destroy (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_shared_mem_create (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_proc_mutex_unlock (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_command_register_action (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_buffer_alloc (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/shared_cache.so ci_proc_mutex_lock (/usr/lib64/c_icap/shared_cache.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so CI_DEBUG_STDOUT (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so __log_error (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_service_data (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_service_set_transfer_preview (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_cfg_conf_table_allocate (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_icap_add_xheader (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_cfg_conf_table_push (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_ring_buf_destroy (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_service_set_preview (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_http_content_length (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_req_unlock_data_non_inline (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_ring_buf_read (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_service_build (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_ring_buf_write (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_service_enable_204 (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_req_hasbody_non_inline (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_ring_buf_new (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_service_set_xopts (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_echo.so ci_req_hasalldata_non_inline (/usr/lib64/c_icap/srv_echo.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so CI_DEBUG_STDOUT (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so __log_error (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_service_data (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_service_set_transfer_preview (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_cfg_conf_table_allocate (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_membuf_write (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_strnstr (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_cfg_conf_table_push (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_service_set_preview (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_http_content_length (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_service_build (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_http_response_remove_header (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_membuf_read (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_service_enable_206 (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_service_enable_204 (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_http_request_add_header (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_req_allow206_non_inline (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_membuf_new (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_http_response_add_header (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_strncasestr (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/srv_ex206.so ci_request_206_origin_body (/usr/lib64/c_icap/srv_ex206.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/sys_logger.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/sys_logger.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/sys_logger.so CI_DEBUG_STDOUT (/usr/lib64/c_icap/sys_logger.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/sys_logger.so __log_error (/usr/lib64/c_icap/sys_logger.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/sys_logger.so ci_cfg_set_str (/usr/lib64/c_icap/sys_logger.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/sys_logger.so ci_format_text (/usr/lib64/c_icap/sys_logger.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/sys_logger.so ci_access_entry_release (/usr/lib64/c_icap/sys_logger.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/sys_logger.so ci_access_entry_add_acl_by_name (/usr/lib64/c_icap/sys_logger.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/sys_logger.so ci_access_entry_new (/usr/lib64/c_icap/sys_logger.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/sys_logger.so ci_access_entry_match_request (/usr/lib64/c_icap/sys_logger.so) c-icap.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/sys_logger.so logformat_fmt (/usr/lib64/c_icap/sys_logger.so) c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf c-icap.x86_64: W: non-standard-uid /run/c-icap c-icap c-icap.x86_64: W: non-standard-uid /var/log/c-icap c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap/c-icap.conf c-icap c-icap.x86_64: W: non-standard-gid /etc/c-icap/c-icap.magic c-icap c-icap.x86_64: W: non-standard-gid /run/c-icap c-icap c-icap.x86_64: W: non-standard-gid /var/log/c-icap c-icap c-icap.x86_64: E: non-standard-dir-perm /etc/c-icap 750 c-icap.x86_64: E: non-standard-dir-perm /var/log/c-icap 750 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.conf 640 c-icap.x86_64: E: non-readable /etc/c-icap/c-icap.magic 640 c-icap-perl.x86_64: W: no-documentation c-icap-libs.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libicapapi.so.0.0.1 SSL_CTX_set_cipher_list 8 packages and 0 specfiles checked; 5 errors, 202 warnings, 5 badness; has taken 2.8 s
Unversioned so-files -------------------- c-icap: /usr/lib64/c_icap/dnsbl_tables.so c-icap: /usr/lib64/c_icap/ldap_module.so c-icap: /usr/lib64/c_icap/lmdb_tables.so c-icap: /usr/lib64/c_icap/shared_cache.so c-icap: /usr/lib64/c_icap/srv_echo.so c-icap: /usr/lib64/c_icap/srv_ex206.so c-icap: /usr/lib64/c_icap/sys_logger.so c-icap-perl: /usr/lib64/c_icap/perl_handler.so
Source checksums ---------------- https://github.com/c-icap/c-icap-server/archive/1238524e71b06f46319c670db4fa... : CHECKSUM(SHA256) this package : e22b160fca1419aa6a9a69b4c559c259f6a8fd0de8a85ad2b652d8fa014467ea CHECKSUM(SHA256) upstream package : e22b160fca1419aa6a9a69b4c559c259f6a8fd0de8a85ad2b652d8fa014467ea
Requires -------- c-icap (rpmlib, GLIBC filtered): /bin/sh config(c-icap) glibc libatomic.so.1()(64bit) libc.so.6()(64bit) libicapapi.so.0()(64bit) liblber.so.2()(64bit) liblber.so.2(OPENLDAP_2.200)(64bit) libldap.so.2()(64bit) libldap.so.2(OPENLDAP_2.200)(64bit) liblmdb.so.0.0.0()(64bit) logrotate rtld(GNU_HASH) shadow-utils
c-icap-devel (rpmlib, GLIBC filtered): /usr/bin/sh c-icap-libs(x86-64) libicapapi.so.0()(64bit) zlib-devel
c-icap-libs (rpmlib, GLIBC filtered): glibc libatomic.so.1()(64bit) libatomic.so.1(LIBATOMIC_1.0)(64bit) libbrotlicommon.so.1()(64bit) libbrotlidec.so.1()(64bit) libbrotlienc.so.1()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libpcre2-8.so.0()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH)
c-icap-perl (rpmlib, GLIBC filtered): c-icap(x86-64) libatomic.so.1()(64bit) libc.so.6()(64bit) libcrypt.so.2()(64bit) libgdbm.so.6()(64bit) libgdbm_compat.so.4()(64bit) libm.so.6()(64bit) libperl.so.5.36()(64bit) libresolv.so.2()(64bit) perl(:MODULE_COMPAT_5.36.1) rtld(GNU_HASH)
c-icap-debuginfo (rpmlib, GLIBC filtered):
c-icap-debugsource (rpmlib, GLIBC filtered):
Provides -------- c-icap: c-icap c-icap(x86-64) config(c-icap)
c-icap-devel: c-icap-devel c-icap-devel(x86-64)
c-icap-libs: c-icap-libs c-icap-libs(x86-64) libicapapi.so.0()(64bit)
c-icap-perl: c-icap-perl c-icap-perl(x86-64)
c-icap-debuginfo: c-icap-debuginfo c-icap-debuginfo(x86-64) debuginfo(build-id)
c-icap-debugsource: c-icap-debugsource c-icap-debugsource(x86-64)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name c-icap --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic, Perl Disabled plugins: Python, SugarActivity, Ocaml, Java, fonts, Haskell, PHP, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #79 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/c-icap
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #80 from Simone Caronni negativo17@gmail.com --- Thanks, I've added you as an admin to the package.
I've added small commits after the import: https://src.fedoraproject.org/rpms/c-icap/commits/rawhide
I've built it on all supported releases, then we can use the packages as build root overrides for the c-icap-modules build/review.
The package fails to build on el7, but I don't recall what we said about supporting el7, so maybe it's fine.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #81 from Frank Crawford frank@crawford.emu.id.au --- We probably should look at what is wrong with el7, as it is still a major enterprise release, and so some people will probably want to install on it.
I suspect it will be pretty easy fix, and will look at it in the next week.
Otherwise that should now close off this review, but we do need to get the others out of the way. They should be quicker.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #82 from Simone Caronni negativo17@gmail.com --- (In reply to Frank Crawford from comment #81)
We probably should look at what is wrong with el7, as it is still a major enterprise release, and so some people will probably want to install on it.
Anyway is going EOL on June 2024, so a year from now.
I suspect it will be pretty easy fix, and will look at it in the next week.
Ok, thanks.
Otherwise that should now close off this review, but we do need to get the others out of the way. They should be quicker.
Thanks, I will close it once we have c-icap and c-icap-modules to push as an update.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #83 from Frank Crawford frank@crawford.emu.id.au --- I think I have found the issue with el7. It doesn't have built-in c11 atomics, so it is the only version that attempts to compile its own atomic_ops functions, and it has a mistake. It is missing an backslash () in line 101, and this addition was only added in Mar 28.
I'll log it upstream, but for now, I'd exclude el7 until it is fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Frank Crawford frank@crawford.emu.id.au changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |CURRENTRELEASE Status|ASSIGNED |CLOSED Last Closed| |2023-06-22 10:45:29
--- Comment #84 from Frank Crawford frank@crawford.emu.id.au --- Following latest upstream commit it no builds on el7 and also non-x86-64 hosts.
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2119985
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2119985 [Bug 2119985] Review Request: squidclamav - HTTP Antivirus for Squid based on ClamAv and the ICAP protocol
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com