https://bugzilla.redhat.com/show_bug.cgi?id=2119983
--- Comment #41 from Simone Caronni <negativo17(a)gmail.com> ---
(In reply to Frank Crawford from comment #35)
> Patches link to upstream bugs/comments/lists or are otherwise
justified.
This really just needs a comment in the spec file.
Done.
> Package should not use obsolete m4 macros
This one comes up from the automated tests in FedoraReview, and I think is
easiest to fix by doing a PR for upstream.
> c-icap.x86_64: W: post-without-tmpfile-creation
/usr/lib/tmpfiles.d/c-icap.conf
This is really just that while you install the tmpfile, it isn't invoked
during the install, so the directory won't be invoked until the next reboot.
There is a %tmpfiles_create macro for use in %post that should fix this.
I've never encountered this macro, so after searching a bit I found that it was
rejected 8 years ago (!) and it never appears in the current packaging
guidelines:
-
https://pagure.io/packaging-committee/issue/439
-
https://fedoraproject.org/wiki/Packaging:Tmpfiles.d
-
https://docs.fedoraproject.org/en-US/packaging-guidelines/Tmpfiles.d/
I see that in /usr/lib/rpm/macros.d/macros.systemd both %tmpfiles_create and
%tmpfiles_create_package are there. Shall I include it anyway?
> c-icap-devel.x86_64: E: incorrect-fsf-address
/usr/include/c_icap/txtTemplate.h
For this I'd log an issue upstream and leave it at that.
> c-icap.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/sbin/c-icap
Again, I'd log it as an issue upstream and leave it at that.
Done, there is also another:
https://github.com/c-icap/c-icap-server/issues/49
Same URL as in comment above, I force pushed as the changes were minimal. New
diff:
https://github.com/scaronni/c-icap/commit/010152d351137bbf20996f9a0933d3b...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2119983