https://bugzilla.redhat.com/show_bug.cgi?id=2224193
Bug ID: 2224193 Summary: Review Request: ipcgull - A GDBus-based IPC library for modern C++ Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: deamicis@bluewin.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://deamn.fedorapeople.org/ipcgull.spec SRPM URL: https://deamn.fedorapeople.org/ipcgull-0.1-0.fc39.src.rpm Description: Ipcgull is a C++ IPC library that takes advantage of modern C++17 features to provide a simple interface for developers to handle IPC. Currently, Ipcgull only supports a D-Bus backend (via GDBus), but this is abstracted by the library and can theoretically be replaced. However, that is out of scope for this project. This project was originally designed solely for use in LogiOps. Fedora Account System Username: deamn
https://bugzilla.redhat.com/show_bug.cgi?id=2224193
Vasiliy Glazov vascom2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@fedoraproject.org |vascom2@gmail.com Doc Type|--- |If docs needed, set a value CC| |vascom2@gmail.com Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2224193
--- Comment #1 from Vasiliy Glazov vascom2@gmail.com --- 1. Why debug_package %{nil} ?
2. Release: 0%{?dist} must be Release: 1%{?dist}
3. Need to change License: GPLv3 to License: GPL-3.0-or-later
4. For devel package need to change Requires: %{name} = %{version}-%{release} to Requires: %{name}%{?_isa} = %{version}-%{release}
5. All at %prep section can be changed to %autosetup
6. install -D -m 755 must be changed to install -D -pm 755
7. Remove %ldconfig_scriptlets
https://bugzilla.redhat.com/show_bug.cgi?id=2224193
--- Comment #2 from Nicolas De Amicis deamicis@bluewin.ch --- Please find the spec and srpm files updated like your review: Spec URL: https://deamn.fedorapeople.org/ipcgull.spec SRPM URL: https://deamn.fedorapeople.org/ipcgull-0.1-1.fc39.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2224193
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1976690 --> https://bugzilla.redhat.com/attachment.cgi?id=1976690&action=edit The .spec file difference from Copr build 6189364 to 6189852
https://bugzilla.redhat.com/show_bug.cgi?id=2224193
--- Comment #4 from Vasiliy Glazov vascom2@gmail.com --- Strange Epoch: 0 and %{cmake} -DPROJECT_EPOCH=%{epoch}
Can you remove this epoch using and set -DPROJECT_EPOCH=0 ?
Seems that for build not need really epoch number from rpm package.
https://bugzilla.redhat.com/show_bug.cgi?id=2224193
--- Comment #5 from Nicolas De Amicis deamicis@bluewin.ch --- (In reply to Vasiliy Glazov from comment #4)
Strange Epoch: 0 and %{cmake} -DPROJECT_EPOCH=%{epoch}
Can you remove this epoch using and set -DPROJECT_EPOCH=0 ?
Seems that for build not need really epoch number from rpm package.
I replaced by a global project variable. The links still the same but the files are updated accordingly to your suggestion.
https://bugzilla.redhat.com/show_bug.cgi?id=2224193
Vasiliy Glazov vascom2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #6 from Vasiliy Glazov vascom2@gmail.com --- My fedora-review fall in exception but all seems good now.
Package Approved.
Don't forget to close this ticket after adding package to the repos.
https://bugzilla.redhat.com/show_bug.cgi?id=2224193
--- Comment #7 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/ipcgull
https://bugzilla.redhat.com/show_bug.cgi?id=2224193
Nicolas De Amicis deamicis@bluewin.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2023-07-24 07:01:23
package-review@lists.fedoraproject.org