https://bugzilla.redhat.com/show_bug.cgi?id=2222279

Benson Muite benson_muite@emailplus.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |benson_muite@emailplus.org Status|NEW |POST Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org Flags| |fedora-review+

--- Comment #2 from Benson Muite benson_muite@emailplus.org --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License". 26 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/python-flexcache/2222279-python- flexcache/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: python3-flexcache-0.2-1.fc38.noarch.rpm python-flexcache-0.2-1.fc38.src.rpm ==================================================== rpmlint session starts ==================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpuces2mze')] checks: 31, packages: 2

===================== 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 5.8 s =====================

Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1

1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.7 s

Source checksums ---------------- https://files.pythonhosted.org/packages/source/f/flexcache/flexcache-0.2.tar... : CHECKSUM(SHA256) this package : 9ab7b6c3afe0fcfee8b60c03faa33ae3db5ad9e48e841f47880bb9efd024e9b0 CHECKSUM(SHA256) upstream package : 9ab7b6c3afe0fcfee8b60c03faa33ae3db5ad9e48e841f47880bb9efd024e9b0

Requires -------- python3-flexcache (rpmlib, GLIBC filtered): python(abi)

Provides -------- python3-flexcache: python-flexcache python3-flexcache python3.11-flexcache python3.11dist(flexcache) python3dist(flexcache)

Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2222279 -m fedora-38-x86_64 Buildroot used: fedora-38-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: SugarActivity, R, C/C++, PHP, Haskell, Ruby, fonts, Java, Ocaml, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comments: a) Approved

https://bugzilla.redhat.com/show_bug.cgi?id=2222279

--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-flexcache

https://bugzilla.redhat.com/show_bug.cgi?id=2222279

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-6c980fa653 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6c980fa653

https://bugzilla.redhat.com/show_bug.cgi?id=2222279

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-0ce6791177 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0ce6791177

https://bugzilla.redhat.com/show_bug.cgi?id=2222279

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-98f88c5f83 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-98f88c5f83

https://bugzilla.redhat.com/show_bug.cgi?id=2222279

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-38aa3c193f has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-38aa3c193f *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-38aa3c193f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

https://bugzilla.redhat.com/show_bug.cgi?id=2222279

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-98f88c5f83 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=2222279

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-38aa3c193f has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=2222279

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-58c68ef0f9 has been pushed to the Fedora EPEL 10.0 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-58c68ef0f9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.