https://bugzilla.redhat.com/show_bug.cgi?id=1317939
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbyszek(a)in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
Too many acronyms. Please spell out what ADS-B messages are and what RTL-SDR
is, and what this package is good for (in the Description).
You cannot use the git commit directly as versions, because git commits are
"random" and versions must always 'grow". See
https://fedoraproject.org/wiki/Packaging:Guidelines#Version_and_Release.
Please put BuildRequires and similar each in a single line (for readability and
git-diffibility).
make %{?_smp_mflags} → %make_build
If Patch1 simply adds a service file, you can just include the service file as
%{SOURCE1} and install it directly. It's easier to inspect and maintain this
way.
systemd-units is long gone, please just use %systemd_requires. Also see
https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd for scriptlets that
need to be added.
%license should be used, see
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text.
Who owns %{_datarootdir}/%{name}/ and %{_datarootdir}/%{name}/public_html ?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component