https://bugzilla.redhat.com/show_bug.cgi?id=1612092
--- Comment #9 from Aurelien Bompard <aurelien(a)bompard.org> ---
- Why does build require git?
This comes from the SELinux module template here:
https://fedoraproject.org/wiki/SELinux/IndependentPolicy#Creating_the_Spe...
I don't know if or why it's necessary, really.
A better alternative would be to use the dependency generator on
Fedora, and
manually specify only for EPEL.
Done.
- You can use %{?systemd_requires} as a shortcut for listing the
per-scriptlet dependencies on systemd
- There is a %{_unitdir} macro for systemd service files
Done.
- %setup, %patch -> %autosetup applies patches automatically
- %{__python3} setup.py build -> %py3_build, %{__python3} setup.py install
-> %py3_install
- Not needed: rm -rf %{buildroot}
- rm -rf src/%{pypi_name}.egg-info -> the egg-info is not binary and must be included
Done. Clearly that specfile was first written a while ago...
Why are we using cron jobs instead of systemd timers?
You're right, I switched to timers.
I've updated the spec file, thanks a lot for your review.
Spec URL:
https://abompard.fedorapeople.org/reviews/mailman3/mailman3.spec
SRPM URL:
https://abompard.fedorapeople.org/reviews/mailman3/mailman3-3.2.0-1.fc28....
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component