https://bugzilla.redhat.com/show_bug.cgi?id=2137932
--- Comment #4 from Neal Gompa <ngompa13(a)gmail.com> ---
Initial spec review notes:
autoreconf -fi
Please add -v to this so we have output logged.
%{make_build}
[...]
%{make_install}
What's with the braces here? It's a bit odd...
# Deduplicate identical files
if cmp %{buildroot}%{_mandir}/man1/{bz3cat,bunzip3}.1; then
rm %{buildroot}%{_mandir}/man1/bunzip3.1
ln -s bz3cat.1 %{buildroot}%{_mandir}/man1/bunzip3.1
fi
This are already solink man pages, this is unnecessarily extra work.
%{_bindir}/*
%{_mandir}/man1/*.1*
This is too promiscuous and needs to be made more restrictive.
Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists
%{_libdir}/libbzip3.so.0
%{_libdir}/libbzip3.so.0.*
This can be simplified to: "%{_libdir}/libbzip3.so.0{,.*}"
%{_libdir}/pkgconfig
This is too promiscuous and needs to be made more restrictive.
Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2137932