Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=887611
--- Comment #18 from Till Bubeck <t.bubeck(a)reinform.de> ---
Mohamed,
Thanks for reviewing the package. I will post an updated version soon.
(In reply to comment #17)
- is there any reason you base your plugin on a git commit? Using the
latest
tag (Frodo_rc3 ) isn't OK? I've been using this tag for a moment with XBMC,
with no particular issue.
You are right, I will change this. At the time I first wrote the SPEC file,
there was no tag at all. This is why I choose the git commit to get a stable
base. However, there is indeed a problem with RC3 (see
https://github.com/opdenkamp/xbmc-pvr-addons/issues/160 for the description and
solution). However, I would like to follow the "official" plugin instead of any
feature clones of others. So I stay with RC3 until Frodo 12 and the addon come
out officially.
- vdr-devel provides many useful RPM macros (see /etc/rpm/macros.vdr)
you
should use instead of those you set on your .spec file:
Thanks for that. I will use it.
- Is there a reason you add extra flags to %{optflags}? I can
understand
-fPIC is needed, but what about all the others?
I will check the others and enter the reasone into the SPEC file.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=cI9PCNlb4P&a=cc_unsubscribe