https://bugzilla.redhat.com/show_bug.cgi?id=1012391
Christopher Meng <cickumqt(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cickumqt(a)gmail.com
--- Comment #1 from Christopher Meng <cickumqt(a)gmail.com> ---
Informal review:
1. Source0:
http://people.defora.org/~khorben/projects/makepasswd/makepasswd-0.5.1.ta...
You should use:
Source0:
http://people.defora.org/~khorben/projects/makepasswd/%{name}-%{version}....
So when you update it to newer version you won't be tired of handling URL
again.
2. Use macro:
/usr/bin --> %{_bindir}
/usr/share/man/man1 --> %{_mandir}/man1
3. install -m 755 src/makepasswd %{buildroot}/usr/bin
install -m 644 doc/makepasswd.1 %{buildroot}/%{_mandir}/man1
You forgot to preserve the timestamp, guidelines tell us that it's a MUST.
4. %defattr(-, root, root -) is not needed now.
5. Don't mark manpages as %doc.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Zn0usFKHBo&a=cc_unsubscribe