https://bugzilla.redhat.com/show_bug.cgi?id=1731583
Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com> ---
Thanks for the quick review, Timothée. Please let me know if I can review
something for you in return. :)
(In reply to Timothée Floure from comment #1)
Gah. Sorry---updated.
* The tests under the check section are not run by default and fail
if
enabled (do not seem related to missing pytest-sugar):
https://paste.sr.ht/~fnux/9aa513ec18533e34f405da400ab027636306fb10
A missing BR: pytest-cov. Added it now. I verified in a virtual environment
that all tests pass. I'll enable them as soon as pytest-sugar is approved.
* The doc subpackage ships quite a lot of third-party web assets
(such as
bootstrap, which is MIT-licensed), which might be a licensing issue. See
https://paste.sr.ht/~fnux/ba797c6e6a3ae7ca90835d9e9e7aa06c3fabaddb for
details. I do not think we can do much, but I think we have to specify the
licenses.
I added MIT to the license list and included a comment explaining it too.
* The `%{?python_enable_dependency_generator}` is no required for
F30+, do
you plan to backport this package to F29?
(
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
#_automatically_generated_dependencies)
Yes. We want to support F29 too.
Unfortunately, the PyPi tar does not contain tests or docs so I must use the
github release.
Updated spec/srpm:
Spec URL:
https://ankursinha.fedorapeople.org/python-pingouin/python-pingouin.spec
SRPM URL:
https://ankursinha.fedorapeople.org/python-pingouin/python-pingouin-0.2.7...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component