https://bugzilla.redhat.com/show_bug.cgi?id=1691022
Numan Siddique <nusiddiq(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nusiddiq(a)redhat.com
--- Comment #3 from Numan Siddique <nusiddiq(a)redhat.com> ---
(In reply to Robert-André Mauchin from comment #2)
Not a review, just a few comments
- Not needed at the start of %install:
rm -rf $RPM_BUILD_ROOT
- Python 2 is deprecated in F30, you shouldn't build new packages with it:
%if 0%{?fedora}
%global with_python2 1
%else
%global with_python2 0
%endif
- Group: is not used in Fedora
CC mrunge or amoralej?
Thanks. I have addressed it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component