https://bugzilla.redhat.com/show_bug.cgi?id=1823151
Fabian Affolter <mail(a)fabian-affolter.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mail(a)fabian-affolter.ch
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Fabian Affolter <mail(a)fabian-affolter.ch> ---
Just some comments to get started...
- URL field is empty ->
https://github.com/devksingh4/thinkpad-tools
- Source0 could be %{pypi_source}
- The descriptions should end with a period.
- LICENSE file must be added to the %files section (%license LICENSE)
- /etc/thinkpad-tools-persistence.sh looks misplaced, only configuration files
should go under /etc
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_configuration...
- Systemd unit files:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#_packa...
- Changelog is missing
Also,
https://github.com/devksingh4/thinkpad-tools/issues/14 should be
addressed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component