https://bugzilla.redhat.com/show_bug.cgi?id=2017179
Alejandro Alvarez <a.alvarezayllon(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |a.alvarezayllon(a)gmail.com
Doc Type|--- |If docs needed, set a value
--- Comment #2 from Alejandro Alvarez <a.alvarezayllon(a)gmail.com> ---
Hello,
From a quick look, I see the following issues:
1. The source code has a LICENSE.md file, which must be included in the rpm
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidel...
2. You should also add the licenses of ConvertUTF (no idea which one, mention
that is not BSD) and wcwidth (0BSD, I guess?) and mention as a comment which
license corresponds to which bit
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidel...
ConvertUTF is also part of llvm, and llvm is shipped within Fedora, so I
imagine its license is ok
3. The ".so" file (unversioned) must go into the -devel package
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
4. The changelog is empty. Add a line indicating this is the initial packaging
of replxx or something of the sort
5. The devel package should depend on the main one
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_bas...
Minor nitpicks
- Use either spaces or tabs, but try not to mix them
- Use preferably an archive named after the project. It can be done as:
https://github.com/AmokHuginnsson/replxx/archive/release-%{version}/%{nam...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2017179