https://bugzilla.redhat.com/show_bug.cgi?id=1290530
--- Comment #3 from Denis Fateyev <denis(a)fateyev.com> ---
I am new to Fedora packaging and should do a couple formal reviews to
show
that I have some idea of the packaging guidelines.
Sure. You might be also interested in my other package review requests, they're
all pretty simple.
On the command line a `rpm -E '%cmake'` tell me that there is
for instance
CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic}" ;
export CXXFLAGS ;
It was broken for a while in rhel6. Actually, it was as follows:
$ rpm -E '%cmake'
CFLAGS="${CFLAGS:--O2 -g}" ; export CFLAGS ;
CXXFLAGS="${CXXFLAGS:--O2 -g}" ; export CXXFLAGS ;
FFLAGS="${FFLAGS:--O2 -g}" ; export FFLAGS ;
/usr/bin/cmake \
-DCMAKE_VERBOSE_MAKEFILE=ON \
-DCMAKE_INSTALL_PREFIX:PATH=/usr \
-DCMAKE_INSTALL_LIBDIR:PATH=/usr/lib64 \
-DINCLUDE_INSTALL_DIR:PATH=/usr/include \
-DLIB_INSTALL_DIR:PATH=/usr/lib64 \
-DSYSCONF_INSTALL_DIR:PATH=/etc \
-DSHARE_INSTALL_PREFIX:PATH=/usr/share \
%if "lib64" == "lib64"
-DLIB_SUFFIX=64 \
%endif
-DCMAKE_SKIP_RPATH:BOOL=ON \
-DBUILD_SHARED_LIBS:BOOL=ON
So I kept workaround for a while. But now it is fixed, and seems I can use
`%cmake` everywhere.
As far as I have understood you can just use `%cmake ..` and get all
the flags needed.
Except for -DMAN_INSTALL_DIR. Prefix can be definitely omitted with `%cmake`.
In the package Eduardo just approved for me I had
`DESTDIR=%{buildroot}`.
As far as I know the two variables are just the same.
They are interchangeable, to be more correct it's macros vs variables style.
Official docs [1] have more info; in short, both can be used but not
arbitrarily mixed in one spec.
# licensedir
I am not really sure what that line is for, could you please tell me?
The license tag isn't supported by rhel6 [2]. For recent Fedora version it's no
longer actual, so kept for compatibility with rhel < 7.
As you may also notice that source URL is formed according the previous GitHub
SourceURL policy. I will update it shortly according the current one [3] (you
can see differences here [4]).
[1]
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot...
[2]
https://fedoraproject.org/wiki/EPEL:Packaging#The_.25license_tag
[3]
https://fedoraproject.org/w/index.php?title=Packaging:SourceURL
[4]
https://fedoraproject.org/w/index.php?title=Packaging:SourceURL&diff=...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component