Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891175
Miro Hrončok <mhroncok(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #8 from Miro Hrončok <mhroncok(a)redhat.com> ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces.
$ rpmlint ../SRPMS/node-gyp-0.8.2-3.fc18.src.rpm
../RPMS/noarch/node-gyp-0.8.2-3.fc18.noarch.rpm
node-gyp.src: W: spelling-error Summary(en_US) js -> dis, ks, j
node-gyp.src: W: spelling-error Summary(en_US) addon -> ad don, ad-don, add on
node-gyp.src: W: spelling-error %description -l en_US js -> dis, ks, j
node-gyp.src: W: spelling-error %description -l en_US addon -> ad don, ad-don,
add on
node-gyp.src: W: spelling-error %description -l en_US waf -> wad, wag, waif
node-gyp.noarch: E: devel-dependency libuv-devel
node-gyp.noarch: E: explicit-lib-dependency libuv-devel
node-gyp.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
node-gyp.noarch: W: spelling-error Summary(en_US) addon -> ad don, ad-don, add
on
node-gyp.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
node-gyp.noarch: W: spelling-error %description -l en_US addon -> ad don,
ad-don, add on
node-gyp.noarch: W: spelling-error %description -l en_US waf -> wad, wag, waif
node-gyp.noarch: W: only-non-binary-in-usr-lib
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/graceful-fs
/usr/lib/node_modules/graceful-fs
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/mkdirp /usr/lib/node_modules/mkdirp
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/rimraf /usr/lib/node_modules/rimraf
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/semver /usr/lib/node_modules/semver
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/npmlog /usr/lib/node_modules/npmlog
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/glob /usr/lib/node_modules/glob
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/minimatch
/usr/lib/node_modules/minimatch
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/request
/usr/lib/node_modules/request
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/nopt /usr/lib/node_modules/nopt
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/tar /usr/lib/node_modules/tar
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/which /usr/lib/node_modules/which
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/fstream
/usr/lib/node_modules/fstream
node-gyp.noarch: W: dangling-symlink
/usr/lib/node_modules/node-gyp/node_modules/osenv /usr/lib/node_modules/osenv
node-gyp.noarch: W: no-manual-page-for-binary node-gyp
2 packages and 0 specfiles checked; 2 errors, 25 warnings.
Symlinks OK, package requires targets.
Devel errors don't apply, as this is a compiler.
TODO: your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense.
All others false positives.
MUST: The package must be named according to the Package Naming Guidelines.
As this is an application and not just a module, nodejs- prefix is not used. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE: MIT, OK.
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/node-gyp-0.8.2.tgz
4346df23bffec9ad3b42c8e138d08fbba2864a76d2fb67477001f6190d19a23c
../SOURCES/node-gyp-0.8.2.tgz
$ spectool -g node-gyp.spec
Getting
http://registry.npmjs.org/node-gyp/-/node-gyp-0.8.2.tgz to
./node-gyp-0.8.2.tgz
$ sha256sum node-gyp-0.8.2.tgz
4346df23bffec9ad3b42c8e138d08fbba2864a76d2fb67477001f6190d19a23c
node-gyp-0.8.2.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense. OK, build
in mock
MUST: Packages must NOT bundle copies of system libraries.
There is a patch for that. OK
MUST: A package must own all directories that it creates. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/node-gyp-0.8.2-3.fc18.noarch.rpm
lrwxrwxrwx 1 root root 44 led 17 09:15
/usr/bin/node-gyp -> ../lib/node_modules/node-gyp/bin/node-gyp.js
drwxr-xr-x 2 root root 0 led 17 09:15
/usr/lib/node_modules/node-gyp
-rw-r--r-- 1 root root 995 led 17 09:15
/usr/lib/node_modules/node-gyp/addon-rpm.gypi
-rw-r--r-- 1 root root 1058 lis 11 22:44
/usr/lib/node_modules/node-gyp/addon.gypi
drwxr-xr-x 2 root root 0 led 17 09:15
/usr/lib/node_modules/node-gyp/bin
-rwxr-xr-x 1 root root 3082 čec 31 19:43
/usr/lib/node_modules/node-gyp/bin/node-gyp.js
drwxr-xr-x 2 root root 0 led 17 09:15
/usr/lib/node_modules/node-gyp/legacy
-rw-r--r-- 1 root root 7158 lis 15 01:37
/usr/lib/node_modules/node-gyp/legacy/common.gypi
drwxr-xr-x 2 root root 0 led 17 09:15
/usr/lib/node_modules/node-gyp/lib
-rw-r--r-- 1 root root 8962 pro 11 17:52
/usr/lib/node_modules/node-gyp/lib/build.js
-rw-r--r-- 1 root root 378 čen 29 2012
/usr/lib/node_modules/node-gyp/lib/clean.js
-rw-r--r-- 1 root root 12812 led 17 09:15
/usr/lib/node_modules/node-gyp/lib/configure.js
-rw-r--r-- 1 root root 12401 pro 21 21:15
/usr/lib/node_modules/node-gyp/lib/install.js
-rw-r--r-- 1 root root 718 čec 17 2012
/usr/lib/node_modules/node-gyp/lib/list.js
-rw-r--r-- 1 root root 4891 říj 2 20:27
/usr/lib/node_modules/node-gyp/lib/node-gyp.js
-rw-r--r-- 1 root root 335 čec 17 2012
/usr/lib/node_modules/node-gyp/lib/rebuild.js
-rw-r--r-- 1 root root 1414 čec 31 22:48
/usr/lib/node_modules/node-gyp/lib/remove.js
drwxr-xr-x 2 root root 0 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules
lrwxrwxrwx 1 root root 29 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/fstream ->
/usr/lib/node_modules/fstream
lrwxrwxrwx 1 root root 26 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/glob -> /usr/lib/node_modules/glob
lrwxrwxrwx 1 root root 33 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/graceful-fs ->
/usr/lib/node_modules/graceful-fs
lrwxrwxrwx 1 root root 31 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/minimatch ->
/usr/lib/node_modules/minimatch
lrwxrwxrwx 1 root root 28 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/mkdirp ->
/usr/lib/node_modules/mkdirp
lrwxrwxrwx 1 root root 26 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/nopt -> /usr/lib/node_modules/nopt
lrwxrwxrwx 1 root root 28 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/npmlog ->
/usr/lib/node_modules/npmlog
lrwxrwxrwx 1 root root 27 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/osenv ->
/usr/lib/node_modules/osenv
lrwxrwxrwx 1 root root 29 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/request ->
/usr/lib/node_modules/request
lrwxrwxrwx 1 root root 28 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/rimraf ->
/usr/lib/node_modules/rimraf
lrwxrwxrwx 1 root root 28 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/semver ->
/usr/lib/node_modules/semver
lrwxrwxrwx 1 root root 25 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/tar -> /usr/lib/node_modules/tar
lrwxrwxrwx 1 root root 27 led 17 09:15
/usr/lib/node_modules/node-gyp/node_modules/which ->
/usr/lib/node_modules/which
-rw-r--r-- 1 root root 976 led 17 09:15
/usr/lib/node_modules/node-gyp/package.json
drwxr-xr-x 2 root root 0 led 17 09:15
/usr/share/doc/node-gyp-0.8.2
-rw-r--r-- 1 root root 1102 čen 29 2012
/usr/share/doc/node-gyp-0.8.2/LICENSE
-rw-r--r-- 1 root root 5957 lis 4 22:09
/usr/share/doc/node-gyp-0.8.2/README.md
OK
MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK
Package APPROVED. Consider working with upstream on a manpage.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=IuTkkPNiAE&a=cc_unsubscribe