https://bugzilla.redhat.com/show_bug.cgi?id=2039649
--- Comment #6 from Miro Hrončok <mhroncok(a)redhat.com> ---
Fedora-Review made me aware of
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_sc...
-- since this package adds a systemd service, we might need to add the
scriptlets.
What is the service actually for and does Cura need it to be up and running?
-------------
Couple more suggestions:
1)
-Summary: File metadata and streaming library for 3D-printing related
file formats.
+Summary: File metadata and streaming library for 3D-printing-related
file formats
2)
-Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz
+Source0: %{url}/archive/%{version}/libCharon-%{version}.tar.gz
Sorry about not spotting that at first, but I think the archive name should ==
the directory in it.
3)
%description
-Charon is a library to read and write several 3D-printing related file formats
+Charon is a library to read and write several 3D-printing-related file
formats.
4)
%package -n python3-charon
Summary: %{summary}
-Provides: charon = %{version}-%{release}
-%{?python_provide:%python_provide python3-charon}
+Provides: libcharon = %{?epoch:%{epoch}:}%{version}-%{release}
+Provides: libcharon%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release}
There are multiple changes here:
- %python_provide is deprecated
- I think it should provide libcharon rather than charon
- the provide should be repeated with architecture
- the provide should contain epoch if it exists (to be more future-proof)
5)
%check
-%{__python3} -m pip freeze
+%{python3} -m pip freeze
%pytest -v
This is a more modern macro that should be used nowadays.
6)
%install
@@ -46,7 +46,7 @@
%files
%license LICENSE
%doc README.md
-%{python3_sitelib}/Charon
+%{python3_sitelib}/Charon/
%{_datadir}/dbus-1/system.d/nl.ultimaker.charon.conf
%{_unitdir}/charon.service
The slash makes the spec file easier to read (the reader immediately knows this
is a directory).
-----------------
I am also trying to figure out f the package needs to runtime-require
dbus-common and systemd or not.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2039649