https://bugzilla.redhat.com/show_bug.cgi?id=1999311
Major Hayden 🤠 <mhayden(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(mhayden(a)redhat.co |
|m) |
--- Comment #2 from Major Hayden 🤠 <mhayden(a)redhat.com> ---
(In reply to Ben Beasley from comment #1)
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== Issues =====
- You should probably add CODE_OF_CONDUCT.md to %doc as well.
Done!
- Version 1.1.0 is available. Is there any reason not to update?
Nope. This one has been sitting for a while. I've updated the spec.
- You should add
%py_provides python3-test-utils
in
%package -n python3-%{srcname}
since the importable name does not match the subpackage suffix.
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
#_the_py_provides_macro.
(Claiming a name like test_utils in a public global namespace for what is
essentially a private helper package seems – to put it kindly – dubious,
but
there are no actual conflicts, and there is nothing you can do about
upstream’s choices here.)
Yeah, I was scratching my head on exactly what to do here since the namespace
is super generic. Fixed that.
- Since python3-devel now (very recently) depends on
pyproject-rpm-macros,
you
can remove:
BuildRequires: pyproject-rpm-macros
Oh nice. One less thing!
Spec URL:
https://download.copr.fedorainfracloud.org/results/mhayden/python-google-...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/mhayden/python-google-...
COPR fedora-review:
https://copr-be.cloud.fedoraproject.org/results/mhayden/python-google-clo...
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1999311