https://bugzilla.redhat.com/show_bug.cgi?id=1636019
--- Comment #10 from jiri vanek <jvanek(a)redhat.com> ---
There is a bug in the luncher:
cp $cpfile $PLUGIN_HOME
This always rewirte custom configuration. Please check for its existence before
copying! This is necessary for this review.
Simialrly, grep for AGENT_STRING is to stroing, isnt it? If I change it, it
will get rewritten. You shold be checking only for AGENT_PATH==, and well, you
dont have this oen extracted in variable at all :)
Few nits:
- procyon decompiler have two members in defautl config, however I have nt
able too find the compiler-tools on web. That casued few issues:
- when I added only path procyon-decompiler, the my changes were silently
scratched, and config was not saved
- after realising it, I removed the tools, and then the config was accepted,
and decompiler worked fine anyway .. so?
- the dialog allows me to edit system (in non root account)files without
warning,and again without warning it do not save them
As the configuration os obviously based on something,, and url is contained in
json can you show it in dialog?
Generally the dialog shod report something. It is obviously doing soem
validations before saving, but it do not tell.
Looking to json file -
"WrapperURL": "DependencyURL":
Both those names are msileading. Thy are pointng to (local)files.
After somehow workarounding those issues, application works great.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component