Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226383
Peter Schiffer <pschiffe(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #5 from Peter Schiffer <pschiffe(a)redhat.com> 2011-08-04 08:24:13 EDT
---
Checked srpm:
$ sha256sum rwall-0.17-33.fc17.src.rpm
6278ae1712bf818a17e1b38fe7c9f984ab2f169a376a300bbd58b8a238a7c4cc
rwall-0.17-33.fc17.src.rpm
YES source files match upstream:
$ sha256sum netkit-rwall-0.17.tar.gz netkit-rwall-0.17.tar.gz.1
97bd59f787d19bc3dff633d35eeb627176574aa7adf65b64a6a4d8dc08f752ed
netkit-rwall-0.17.tar.gz
97bd59f787d19bc3dff633d35eeb627176574aa7adf65b64a6a4d8dc08f752ed
netkit-rwall-0.17.tar.gz.1
INFO clean section is not present, buildroot section is.
YES latest version is being packaged.
YES BuildRequires are proper.
YES rpmlint is silent.
$ rpmlint rwall.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint rwall-0.17-33.fc17.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint rwall-0.17-33.fc17.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint rwall-server-0.17-33.fc17.x86_64.rpm
rwall-server.x86_64: E: script-without-shebang
/lib/systemd/system/rwalld.service
- false positive
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
$ rpmlint rwall-debuginfo-0.17-33.fc17.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Additional comments:
* URL tag should be in upper-case
* %build section could be simplified by removing perl
None of these comments is blocking the approval -> APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.