https://bugzilla.redhat.com/show_bug.cgi?id=1906490
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |decathorpe(a)gmail.com
Flags| |fedora-review?
--- Comment #7 from Fabio Valentini <decathorpe(a)gmail.com> ---
Several comments I'd like to make before a final / formal review:
1) please update to 0.11.6, it was released a month ago
2) Version 0.11.6 apparently requires setuptools >= 46.1, adapt the version in
your BRs and Requires.
3) These explicit Requires are not necessary:
Requires: python3-semantic_version >= 2.6.0
Requires: python3-toml >= 0.9.0
They are 1:1 encoded by the python package metadata like this, so the
dependency generator will automatically add those for you.
(See
/usr/lib/python3.9/site-packages/setuptools_rust-0.11.5-py3.9.egg-info/requires.txt
in the built RPM.)
3) If you expect users of this package to have to use %cargo macros from
fedora, you could just add "Requires: rust-packaging".
rust-packaging automatically pulls in cargo, rustc, and the package containing
Rust macros.
4) Add trailing slashes to the directories listed in %files:
%{python3_sitelib}/setuptools_rust/
%{python3_sitelib}/setuptools_rust-%{version}-py%{python3_version}.egg-info/
This prevents issues should those ever be changed to files (or vice-versa).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component