https://bugzilla.redhat.com/show_bug.cgi?id=1109049
Lubomir Rintel <lkundrak(a)v3.sk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lkundrak(a)v3.sk
--- Comment #2 from Lubomir Rintel <lkundrak(a)v3.sk> ---
This looks very nicely done.
* Package correctly named
* Latest version packaged
- License NOT correct (see below)
* License ok for Fedora
* SPEC file clean and legible
* Builds fine in mock
* Requires fine
* Provides fine
* Filelist fine
* Proper ldconfig scriptlets in place
There are some problems though:
0.) The license tag does not seem correct
According to libcsv.c it's LGPLv2+
1.) License text is missing
Please add %doc COPYING.LESSER. No idea why upstream ships GPL in COPYING;
nothing seems to be GPL-ed in the library; no need to ship that file.
2.) It's customary for RPMs to be portable across installations with manpage
compression turned off to do this:
-%doc %{_mandir}/man3/csv.3.gz
+%doc %{_mandir}/man3/csv.3*
3.) You may use %{version} macro to substitute versions for easier version
upgrades. This one is completely up to you -- not a review blocker.
By the way, upstream seems to use a weird name for their library; they probably
intended to use libcsv.so.3.0.3 instead of libcsv.so.3.0.2./csv.3.gz
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component