https://bugzilla.redhat.com/show_bug.cgi?id=1767998
Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dominik(a)greysector.net
--- Comment #1 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net>
---
Some quick comments:
https://gitlab.com/LyesSaadi/spec/blob/master/mbpfan/mbpfan.spec#L9
It's a matter of preference, but I'd recommend putting each build dependency in
a separate line and sorting them alphabetically.
https://gitlab.com/LyesSaadi/spec/blob/master/mbpfan/mbpfan.spec#L30
Please use %make_build macro unless you have a good reason not to. I don't see
Fedora-mandated compiler flags being used during build, so please try adding
%set_build_flags before calling make and if that doesn't help, you might need
to patch the Makefile.
https://gitlab.com/LyesSaadi/spec/blob/master/mbpfan/mbpfan.spec#L32
You can fold each mkdir+cp pair into install -Dp call to make it shorter, but
do at least use cp -p to preserve build-time timestamps.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component