https://bugzilla.redhat.com/show_bug.cgi?id=834127
Orion Poplawski <orion(a)cora.nwra.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |orion(a)cora.nwra.com
Assignee|nobody(a)fedoraproject.org |orion(a)cora.nwra.com
--- Comment #2 from Orion Poplawski <orion(a)cora.nwra.com> ---
Couple initial comments:
- Please update to 2.3.1
- Blank lines between changelog entries
- mesa-libGLU-devel will bring in libX11-devel, libXext-devel, and
mesa-libGL-devel, so no need to list them.
- The -devel Requires need %{?_isa} added
- You need to use %cmake28 in EPEL6
- I would change the cmake conditional to:
%if 0%{?rhel} == 6
BuildRequires: cmake28
%else
BuildRequires: cmake
%endif
and
%if 0%{?rhel} == 6
%cmake28 -DTJPEG_INCLUDE_DIR=%{_includedir} \
%else
%cmake -DTJPEG_INCLUDE_DIR=%{_includedir} \
%endif
As that is the exceptional condition.
- I recommend doing out of tree builds for cmake, but this isn't necessary.
rpmlint:
VirtualGL.x86_64: E: invalid-soname /usr/lib64/libdlfaker.so libdlfaker.so
VirtualGL.x86_64: E: invalid-soname /usr/lib64/librrfaker.so librrfaker.so
VirtualGL.x86_64: E: invalid-soname /usr/lib64/libgefaker.so libgefaker.so
These get preloaded via the vglrun wrapper script. I think they should go into
%{_libdir}/VirtualGL.
VirtualGL.x86_64: W: shared-lib-calls-exit /usr/lib64/librrfaker.so
exit(a)GLIBC_2.2.5
can be ignored
VirtualGL.x86_64: E: incorrect-fsf-address
/usr/share/doc/VirtualGL-2.3/LGPL.txt
contact upstream and tell them to fix that.
--
You are receiving this mail because:
You are on the CC list for the bug.