https://bugzilla.redhat.com/show_bug.cgi?id=1063047
Mo Morsi <mmorsi(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mmorsi(a)redhat.com
--- Comment #1 from Mo Morsi <mmorsi(a)redhat.com> ---
Hey Nitesh, some comments (similar to em-socksify)
- Gemfile, README, Rakefile, gemspec files should be marked as %doc
- Please rm the .document and .rspec files at some point during the build
process
- Build fails again since you use rspec and assumably eventmachine is needed to
run the test suite, yet neither are listed as Build Requirements on the
package.
- Consider removing the extraneous whitespace / blank lines.
If you could fix these & successfully build the package via koji I'll give you
the official review. Additionally if rspec / eventmachine are BuildRequirements
for the other packages you submitted (noticed it was the case for
eventmachine_httpserver as well) but aren't listed in the specs, please add
them so as to tackle this issue across them all.
Thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component