https://bugzilla.redhat.com/show_bug.cgi?id=2090823
--- Comment #10 from Jeremy Newton <alexjnewt(a)fastmail.com> ---
(In reply to Luya Tshimbalanga from comment #9)
Created attachment 1894588 [details]
Full Review
Skipping already reviewed part (full review attached) and addressed fixed.
How about changing
%if 0%{?enable_ocltst}
BuildRequires: glew-devel
%endif
BuildRequires: gcc-c++
BuildRequires: libglvnd-devel
to
%if 0%{?enable_ocltst}
BuildRequires: pkgconfig(glew)
%endif
BuildRequires: gcc-c++
BuildRequires: pkgconfig(opengl)
Sounds good, I can do that before I import.
If you like, use %autorelease and %autochangelog macros for Release and
%changelog respectively.
I'm still not quite convinced that it really saves all that much time, but
thanks for the tip.
According the full review, the package is ready for the main repository thus
APPROVED. Make sure to implement the above suggestion before importing.
Thanks again for the review!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2090823