https://bugzilla.redhat.com/show_bug.cgi?id=1350257
--- Comment #8 from Antonio Trande <anto.trande(a)gmail.com> ---
(In reply to Dave Love from comment #6)
I had trouble running the review tool as I have to use a VM, and the
build
takes a lot of memory, but there are some problems and queries I have with
the spec anyhow.
* I think the --with-mpi-lib and --with-mpi-include configure args should
be removed.
They aren't necessary, and running pkg-config actually fails. The %(env
is
evaluated at the wrong time and causes complaints, but there's no config
file
anyhow in at least el6, and it's unnecessary -- the mpi compiler wrapper
will
find the bits. Are the other pkg-configs actually necessary?
Any better option instead of pkg-config calls for mpi libs?
* The Requires: for petsc64-devel is misplaced and its description line is
too long.
Fixed.
* Why do the main packages require gfortran? That can't be right.
It requires libgfortran ...
Or I'm in wrong?
* The Fortran .mod files should be in -devel packages.
Fixed.
* Do you have an opinion on whether a complex version is useful?
Debian builds that, but only slepc-complex depends on it.
I have not idea
(In reply to Dave Love from comment #7)
Oh, something else. PAPI is a mess on el6. You need to ensure you
get v5
for at least sandybridge+. This is what I had to do for scorep:
# The messing with linkage paths here and below is due to the mess of
# the papi package there. %%_libdir/libpapi.so is papi v4 with a
# soname of libpapi.so (bz #1300664).
export LDFLAGS='-Wl,--as-needed -L%{_libdir}/papi-5.1.1/usr/lib'
%global configure_opts --enable-shared --disable-static
--disable-silent-rules
%{?el6:--with-papi-header=%{_libdir}/papi-5.1.1%{_includedir}
--with-papi-lib=%{_libdir}/papi-5.1.1/usr/lib}
I have added compiler/linker flags with a rpath.
SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/petsc/petsc.git/p...
SRPM:
https://copr-be.cloud.fedoraproject.org/results/sagitter/petsc/fedora-raw...
Copr builds:
http://copr-fe.cloud.fedoraproject.org/coprs/sagitter/petsc/build/440220/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component