Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=528096
--- Comment #13 from Ryan Rix <phrkonaleash(a)gmail.com> 2009-10-18 01:47:01 EDT ---
* escape (double) the % signs in %changelog (MUST)
Done
* own the following 2 directories:
%{_kde4_docdir}/HTML/en/%{name}/
%{_kde4_appsdir}/kMagnet/
not just the files they contain (i.e. remove the * at the end of those lines)
(MUST)
Done
* remove the unnecessary lines from the %postun and %posttrans
scriptlets:
update-desktop-database -q &> /dev/null
update-mime-database %{_kde4_datadir}/mime &> /dev/null
(SHOULD, and trivial to fix, so please fix this while you are at fixing
things unless you have a good reason not to)
Done
* ask upstream to include a copy of the GPLv3 to match their license
headers
(SHOULD, but you don't have to wait for an answer to get the package approved)
Sent a mail upstream with this and other issues you and I discussed in IRC.
=======================
[rrix@TheSwan rpmbuild]$ rpmlint RPMS/i586/kmagnet-0.03-5.fc11.i586.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[rrix@TheSwan rpmbuild]$ rpmlint SRPMS/kmagnet-0.03-5.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[rrix@TheSwan rpmbuild]$ rpmlint
RPMS/i586/kmagnet-debuginfo-0.03-5.fc11.i586.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1752652
http://rrix.fedorapeople.org/kmagnet/kmagnet-0.03-5.fc11.src.rpm
http://rrix.fedorapeople.org/kmagnet/kmagnet.spec
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.