https://bugzilla.redhat.com/show_bug.cgi?id=828993
--- Comment #4 from John Morris <john(a)zultron.com> ---
Hi Benedikt, here are a few issues, the first detected by fedora-review, the
rest I found myself. Be sure to check the attached review. I checked most of
the items, but left a few blank.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
** rm -rf %{buildroot} in %install; is this intended for EPEL5?
[!]: MUST Package consistently uses macros (instead of hard-coded directory
names).
** There is an %{_iconsdir} macro; could replace %{_datadir}/icons
** There is a %{_desktopdir} macro; could replace %{_datadir}/applications
[!]: MUST Package does not own files or directories owned by other packages.
** Does this pkg need to own all those directories in %{_iconsdir}?
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Patch0: l3afpad-0.8.18.1.9-missing-semicolon.patch
(l3afpad-0.8.18.1.9-missing-semicolon.patch)
** I'd put:
** Patch0: %{name}-%{version}-missing-semicolon.patch
--
You are receiving this mail because:
You are on the CC list for the bug.