Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894551
Kevin Fenzi <kevin(a)scrye.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |kevin(a)scrye.com
Flags| |fedora-review+
--- Comment #3 from Kevin Fenzi <kevin(a)scrye.com> ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (BSD)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
f01eb9027e9eb56aeaeef636649877756d475d714ef8b47f627f65bc5f3b492f
libffi-3.0.10.tar.gz
f01eb9027e9eb56aeaeef636649877756d475d714ef8b47f627f65bc5f3b492f
libffi-3.0.10.tar.gz.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Spec has needed ldconfig in post and postun
OK - .la files are removed.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
OK - No rpmlint output.
OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
Issues:
1. Minor nits:
The "# part of upstream commit 5feacad4" looks like a leftover. remove.
Unless you intend to support old rhels:
- Remove BuildRoot
- Remove clean section
- Remove rm -rf at the top of install
Might mention in the description that this is a compat package for old
versions.
2. rpmlint says:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
I Don't see any blockers here so this package is APPROVED.
You can correct the nitpicks before import. ;)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=RwGKhef8Wd&a=cc_unsubscribe