https://bugzilla.redhat.com/show_bug.cgi?id=2008090
--- Comment #9 from Andreas Krebbel <krebbel1(a)de.ibm.com> ---
(In reply to Dan Horák from comment #8)
Thanks, the 0.3.1-2 looks good to me. One minor nitpick - please add
a new
line between the %changelog entries.
Done
Regarding the -march flags, I think that one option could be removing
the
distro values from %optflags and then relying on the upstream mechanism to
set the -march=z14. Something like
%global optflags $(echo %optflags | sed -e 's/-march=z[[:alnum:]]\+//g' -e
's/-mtune=z[[:alnum:]]\+//g')
In the current revision you likely end up with -march=z14 -mtune=z13
combination, which might be suboptimal.
Right, but for the init routines I still want the distro defaults and once the
distro defaults are z14 or higher we always want the distro default to
overwrite the upstream options. So for now I've just added also -mtune=z14 to
the override options.
Here are the updated versions of the files. Thanks for your feedback!
SPEC:
https://ankr.fedorapeople.org/libzdnn.spec
SRPM:
https://ankr.fedorapeople.org/libzdnn-0.3.1-3.fc33.src.rpm
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2008090