https://bugzilla.redhat.com/show_bug.cgi?id=1650943
--- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com> ---
(In reply to Manas Mangaonkar (Pac23) from comment #1)
Not a Official Review
---------------------------------------------------------------
Thanks for the review, Manas.
Issues:
=======
- Header files in -devel subpackage, if present.
Note: biosig4c++-debugsource :
These are in the debug package, not in the devel package.
It is required. It is a C++ library and the mock build fails if g++ is not
available.
/bin/sh: g++: command not found
from
https://kojipkgs.fedoraproject.org//work/tasks/3700/30963700/build.log
https://koji.fedoraproject.org/koji/taskinfo?taskID=30963700
- ldconfig called in %post and %postun if required.
Note: /sbin/ldconfig not called in biosig4c++
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
It is:
%ldconfig_scriptlets
but, these are no longer required on F28+:
"On Fedora 28 and newer, no scriptlets are required when shared libraries are
installed. However, the following scriptlets MAY be used, as they will simply
evaluate to nothing on newer Fedora releases.
On Fedora 27 and older, ldconfig MUST be called properly in order to regenerate
the dynamic linker's cache. If the package or subpackage has no existing %post
or %postun scriptlets, simply include the %ldconfig_scriptlets macro on its own
line before the %files list."
https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_Libraries
I'm leaving it in, in case I build for F27.
Installs and builds fine,although i did get no upstream for source thing
while building it in mock
This is in the spec. If it isn't clear enough, please let me know and I can
improve it.
# Fetch the snapshot---this contains code for other biosig tools also which we
don't need
# git clone
https://git.code.sf.net/p/biosig/code biosig-all
# cd biosig-all
# Remove symlink and replace with actual files
# rm biosig4c++/extern -f
# cp -r biosig4matlab/doc biosig4c++/extern
# tar -cvzf biosig4c++-1.9.3-94296e0ee92c39636235d390c313ad1dfe644a88.tar.gz
biosig4c++/
Source0: %{name}-%{version}-%{commit}.tar.gz
Cheers,
Ankur
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component