https://bugzilla.redhat.com/show_bug.cgi?id=1869719
Vít Ondruch <vondruch(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vondruch(a)redhat.com
--- Comment #3 from Vít Ondruch <vondruch(a)redhat.com> ---
* Unversioned `%gemspec_remove`
- I don't like the usage of `%gemspec_remove` without specifying versions.
If I am not mistaken, when the dependency is removed upstream, then it
would pass without noticing. It is not really big deal, but it is nice
to know there is something to remove if it is not needed anymore.
* `skip` vs `return`
- It probably won't make any real difference, but wouldn't it be better to
use `sed -i '/Vips::/ i \ return' test/test_helper.rb` instead of
`sed -i '/Vips::/ i \ skip' test/test_helper.rb`?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component