https://bugzilla.redhat.com/show_bug.cgi?id=2119091
Jakub Kadlčík <jkadlcik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jkadlcik(a)redhat.com
--- Comment #1 from Jakub Kadlčík <jkadlcik(a)redhat.com> ---
Hello again Major,
thank you for the package.
# No tests provided by upstream. 😢
Can you please drop the special characters at the end?
%if %{with tests}
BuildRequires: python3dist(azure-devtools)
BuildRequires: python3dist(azure-mgmt-keyvault)
BuildRequires: python3dist(azure-mgmt-resource)
BuildRequires: python3dist(azure-sdk-tools)
BuildRequires: python3dist(pytest)
BuildRequires: python3dist(pytest-aiohttp)
BuildRequires: python3dist(python-dotenv)
%endif
It's a bit strange to me that we have test-specific BuildRequires when
there are no tests provided by upstream :-). But I don't really mind.
%global _description %{expand:
Microsoft Azure Dashboard Management Client Library for Python}
Please try to avoid duplicating the summary. I am not sure if there is
some copy-pastable text in the upstream documentation. If not, please
just write 2-3 simple sentences about the package.
%files -n python3-%{srcname} -f %{pyproject_files}
%doc README.md CHANGELOG.md
I think we should add %license LICENSE as well. The same reasoning as
for RHBZ 2116843 (I will try to ask some python people so we are sure
the next time).
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2119091