https://bugzilla.redhat.com/show_bug.cgi?id=967782
--- Comment #2 from Björn Esser <bjoern.esser(a)gmail.com> ---
Created attachment 754886
-->
https://bugzilla.redhat.com/attachment.cgi?id=754886&action=edit
Makefile shouldn't modify %{_sysconfdir}/shells
A quick view over the spec-file reveales:
* Since this is a daemon, spec-file should enable hardened build:
%global _hardened_build 1
* There's no need for Requires: python, rpmbuild will pick this up
automaticly.
* BuildRequires: autoconf, automake but no autoreconf -vfi during %prep.
* Makefile alters /etc/shells during build
use attached patch
* %post should add `jk_chrootsh` to /etc/shells, using this scriptlet:
if [ -w %{_sysconfdir}/shells ] && \
[ "`grep %{_sbindir}/jk_chrootsh %{_sysconfdir}/shells`" ==
"" ]
then
echo "%{_sbindir}/jk_chrootsh" >> %{_sysconfdir}/shells
fi
* %postun should remove `jk_chrootsh` from /etc/shells, using sed:
sed -i -e "/jk_chrootsh/d" %{_sysconfdir}/shells
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=UbU9QVoIYM&a=cc_unsubscribe