Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711547
Richard Shaw <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hobbes1069(a)gmail.com
--- Comment #12 from Richard Shaw <hobbes1069(a)gmail.com> 2011-07-02 10:09:19 EDT
---
I can't sponsor you but I can suggest some fixes to your spec.
You still need to update your License tag per comment 5.
You don't need BuildRoot unless you're planning on building for EPEL <= 5
You don't need %clean unless you're planning on building for EPEL, in fact
leaving it in without the accompanying "rm -rf %{buildroot}" is worse.
You don't need "rm -rf %{buildroot}" in %install unless you're planning
to
build for EPEL <= 5.
I assume that since you're manually installing the binary that this package
lacks a "make install" target?
All of your "%doc" items can be listed space separated on one line.
You need to add one empty line between your changelog entries, e.g.:
%changelog
* Mon Jun 26 2011 Ryan H. Lewis <me(a)ryanlewis.net> 1.0-3
- Added ChangeLog
* Mon Jun 9 2011 Ryan H. Lewis <me(a)ryanlewis.net> 1.0-2
- Fixes
https://bugzilla.redhat.com/show_bug.cgi?id=711547#c5
* Mon Jun 7 2011 Ryan H. Lewis <me(a)ryanlewis.net> 1.0-1
- Created initial spec file
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.