Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=813420
--- Comment #2 from Brendan Jones <brendan.jones.it(a)gmail.com> 2012-04-17 15:02:30
EDT ---
Looking good, just a few things:
- missing scriptlets for the icon cache.
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- you can drop the index.html from the URL, but please use %name/%version
macros in URL, Source, Patch etc where appropriate
- I'd like you to be a little more verbose in the %files section (for the
binaries and desktop files at least) as I think it reads better. Similarly with
the man section although its best to use a wildcard for the extension rather
than .gz
- you also need to use the %find_lang %{name} --with-qt to grab the .qm files
(even though they are under the application dir - its still a must)
http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.