https://bugzilla.redhat.com/show_bug.cgi?id=823166
--- Comment #1 from Petr Pisar <ppisar(a)redhat.com> ---
Source file is original. Ok.
Summary verified from lib/B/Hooks/OP/Check/EntersubForCV.pm. Ok.
License verified from lib/B/Hooks/OP/Check/EntersubForCV.pm. Ok.
Description is Ok.
URL and Source0 are usable. Ok.
There is an XS code, BuildArch is Ok.
FIX: Build-require `perl(inc::Module::Install)' (Makefile.PL:3).
FIX: Build-require Perl modules needed by bundled inc/* files (e.g.
`perl(Cwd)') or, which I recommend, remove the inc content (be ware of
inc/.author to skip author tests). Then you do not need to build-require
perl(ExtUtils::MakeMaker).
All tests pass. Ok.
$ rpmlint perl-B-Hooks-OP-Check-EntersubForCV.spec
../SRPMS/perl-B-Hooks-OP-Check-EntersubForCV-0.09-1.fc18.src.rpm
../RPMS/x86_64/perl-B-Hooks-OP-Check-EntersubForCV-*
perl-B-Hooks-OP-Check-EntersubForCV.src: W: spelling-error Summary(en_US)
entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.src: W: spelling-error %description -l
en_US entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.x86_64: W: spelling-error Summary(en_US)
entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.x86_64: W: spelling-error %description -l
en_US entersub -> enter sub, enter-sub, subtenant
perl-B-Hooks-OP-Check-EntersubForCV.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/perl5/vendor_perl/B/Hooks/OP/Check/EntersubForCV/Install/hook_op_check_entersubforcv.h
perl-B-Hooks-OP-Check-EntersubForCV-debuginfo.x86_64: E:
description-line-too-long C This package provides debug information for package
perl-B-Hooks-OP-Check-EntersubForCV.
3 packages and 1 specfiles checked; 1 errors, 5 warnings.
rpmlint is Ok.
$ rpm -q -lv -p
../RPMS/x86_64/perl-B-Hooks-OP-Check-EntersubForCV-0.09-1.fc18.x86_64.rpm
drwxr-xr-x 2 root root
0 May 23 18:12 /usr/lib64/perl5/vendor_perl/B
drwxr-xr-x 2 root root 0 May 23 18:12
/usr/lib64/perl5/vendor_perl/B/Hooks
drwxr-xr-x 2 root root 0 May 23 18:12
/usr/lib64/perl5/vendor_perl/B/Hooks/OP
drwxr-xr-x 2 root root 0 May 23 18:12
/usr/lib64/perl5/vendor_perl/B/Hooks/OP/Check
drwxr-xr-x 2 root root 0 May 23 18:12
/usr/lib64/perl5/vendor_perl/B/Hooks/OP/Check/EntersubForCV
-rw-r--r-- 1 root root 3111 Mar 12 20:48
/usr/lib64/perl5/vendor_perl/B/Hooks/OP/Check/EntersubForCV.pm
drwxr-xr-x 2 root root 0 May 23 18:12
/usr/lib64/perl5/vendor_perl/B/Hooks/OP/Check/EntersubForCV/Install
-rw-r--r-- 1 root root 610 May 23 18:12
/usr/lib64/perl5/vendor_perl/B/Hooks/OP/Check/EntersubForCV/Install/Files.pm
-rw-r--r-- 1 root root 414 Sep 10 2011
/usr/lib64/perl5/vendor_perl/B/Hooks/OP/Check/EntersubForCV/Install/hook_op_check_entersubforcv.h
drwxr-xr-x 2 root root 0 May 23 18:12
/usr/lib64/perl5/vendor_perl/auto/B
drwxr-xr-x 2 root root 0 May 23 18:12
/usr/lib64/perl5/vendor_perl/auto/B/Hooks
drwxr-xr-x 2 root root 0 May 23 18:12
/usr/lib64/perl5/vendor_perl/auto/B/Hooks/OP
drwxr-xr-x 2 root root 0 May 23 18:12
/usr/lib64/perl5/vendor_perl/auto/B/Hooks/OP/Check
drwxr-xr-x 2 root root 0 May 23 18:12
/usr/lib64/perl5/vendor_perl/auto/B/Hooks/OP/Check/EntersubForCV
-rwxr-xr-x 1 root root 10400 May 23 18:12
/usr/lib64/perl5/vendor_perl/auto/B/Hooks/OP/Check/EntersubForCV/EntersubForCV.so
drwxr-xr-x 2 root root 0 May 23 18:12
/usr/share/doc/perl-B-Hooks-OP-Check-EntersubForCV-0.09
-rw-r--r-- 1 root root 1121 Mar 12 20:49
/usr/share/doc/perl-B-Hooks-OP-Check-EntersubForCV-0.09/Changes
-rw-r--r-- 1 root root 2496 Sep 26 2011
/usr/share/doc/perl-B-Hooks-OP-Check-EntersubForCV-0.09/README
-rw-r--r-- 1 root root 2786 May 23 18:12
/usr/share/man/man3/B::Hooks::OP::Check::EntersubForCV.3pm.gz
File permissions and layout are Ok.
$ rpm -q --requires -p
../RPMS/x86_64/perl-B-Hooks-OP-Check-EntersubForCV-0.09-1.fc18.x86_64.rpm |sort
|uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 perl(B::Hooks::OP::Check) >= 0.19
1 perl(B::Utils) >= 0.19
1 perl(DynaLoader)
1 perl(:MODULE_COMPAT_5.14.2)
1 perl(parent)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 rtld(GNU_HASH)
Binary requires are Ok.
$ rpm -q --provides -p
../RPMS/x86_64/perl-B-Hooks-OP-Check-EntersubForCV-0.09-1.fc18.x86_64.rpm |sort
|uniq -c
1 perl(B::Hooks::OP::Check::EntersubForCV) = 0.09
1 perl-B-Hooks-OP-Check-EntersubForCV = 0.09-1.fc18
1 perl(B::Hooks::OP::Check::EntersubForCV::Install::Files)
1 perl-B-Hooks-OP-Check-EntersubForCV(x86-64) = 0.09-1.fc18
Binary provides are Ok.
TODO: What the perl(B::Hooks::OP::Check::EntersubForCV::Install::Files)? It
seems like a auto-generated Provides based on the file name. Why the file is
installed? It's content is identical to B::Hooks::OP::Check::EntersubForCV. Is
the file necessary? ExtUtils::Depends::save_config() explains that's for
backward compatibility. It think you can filter this symbol from set of
Provides.
$ resolvedeps rawhide
../RPMS/x86_64/perl-B-Hooks-OP-Check-EntersubForCV-0.09-1.fc18.x86_64.rpm
Binary dependencies resolvable. Ok.
Package builds in F18
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=4096693). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct all `FIX' prefixed issues, consider fixing `TODO' items and
provide new spec file.
Resolution: Package NOT approved.
--
You are receiving this mail because:
You are on the CC list for the bug.