Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Mediatomb - UPnP AV Mediaserver for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=426733
mtasaka(a)ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody(a)fedoraproject.org |mtasaka(a)ioa.s.u-tokyo.ac.jp
Status|NEW |ASSIGNED
Flag| |fedora-review?
------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2008-01-02 05:01 EST
-------
For 0.10.0-3:
* Conditional BuildRequires:
- Still build.log says:
-----------------------------------------------------
327 CONFIGURATION SUMMARY ----
328
329 sqlite3 : yes
330 mysql : yes
331 libjs : yes
332 libmagic : yes
333 inotify : yes
334 libexif : yes
335 id3lib : yes
336 taglib : disabled
337 libextractor : disabled
-----------------------------------------------------
A. For taglib, configure.ac says:
-----------------------------------------------------
1659 AC_ARG_ENABLE(id3lib,
1660 AC_HELP_STRING([--enable-id3lib], [compile with taglib support
(default: yes, preferred over taglib)]),
1677 AC_ARG_ENABLE(taglib,
1678 AC_HELP_STRING([--enable-taglib], [compile with taglib support
(default: yes, if id3lib is not available)]),
-----------------------------------------------------
So as id3lib is preferred, having taglib disabled can be
ignored.
B. For libextractor, configure.ac says:
-----------------------------------------------------
1982 AC_ARG_ENABLE(libextractor,
1983 AC_HELP_STRING([--enable-libextractor], [compile with
libextractor support (default: no)]),
-----------------------------------------------------
So it seems that explicit configure option "--enable-libextractor"
is needed.
* Patches
- Patch0 and Patch1 are not applied??
* Macros
- Please use %_sysconfdir for /etc
(useradd -r -g mediatomb -d /etc/mediatomb ..... )
%_localstatedir for /var
- Also, for consistency please replace with
make -> %__make
install -> %__install
rm -> %__rm
* Directory ownership
- Still %_sysconfdir/mediatomb/ is not owned by this package
and you removed the lines to create/chown the directory %_sysconfdir/mediatomb/
by %PATCH0. Perhaps with this "service mediatomb" won't start.
Also, when removing mediatomb rpm, all files under %_sysconfdir/mediatomb
are left unremoved as these files are not owned by any package
To
- Create %_sysconfdir/mediatomb with proper ownership
- Make it sure that all files under %_sysconfdir/mediatomb/ are removed
properly when removing mediatomb
Please add following:
------------------------------------------------------------
%install
........
%{__make} install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
# make all files under %%_sysconfdir/mediatomb are owned by
# this package
%{__mkdir_p} $RPM_BUILD_ROOT%{_sysconfdir}/mediatomb
touch
$RPM_BUILD_ROOT%{_sysconfdir}/mediatomb/{config.xml,mediatomb.db,mediatomb.html}
%{__mkdir_p} %{buildroot}%{_sysconfdir}/logrotate.d
......
%files
%defattr(-,root,root,-)
......
%attr(-,mediatomb,mediatomb) %config(noreplace) %{_sysconfdir}/mediatomb.conf
%attr(-,mediatomb,mediatomb) %dir %{_sysconfdir}/mediatomb/
%attr(-,mediatomb,mediatomb) %ghost %{_syscondir}/mediatomb/*
%config(noreplace) %{_sysconfdir}/logrotate.d/%{name}
......
------------------------------------------------------------
(In reply to comment #8)
Note:
you need at least one database in order to compile and run MediaTomb -
either sqlite or mysql.
I know in Debian you can use || for or but I'm not to sure
what it is in Fedora.
- For this package it is easier to write "Requires:
mysql" (as you are doing
now) because mediatomb binary is already linked against both sqlite and
mysql library.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.