https://bugzilla.redhat.com/show_bug.cgi?id=1372866
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbyszek(a)in.waw.pl
--- Comment #32 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
You should provide a symlink to the spec file and srpm file directly in
comments, so that fedora-review can find them:
spec file:
https://jtaylor.fedorapeople.org/hyperscan/hyperscan.spec
srpm:
https://jtaylor.fedorapeople.org/hyperscan/hyperscan-4.4.1-1.fc27.src.rpm
This
isn't useful — you are renaming the tarball to the original (bad) name.
You want ...#/hyperscan-%{gittag0}.tar.gz
Patch0: path.patch
A more descriptive patch name would
be nice.
make %{?_smp_mflags}
%make_build
make install DESTDIR=%{buildroot}
%make_install
hyperscan.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line
4)
In the build I see various -m64 -mtune=generic, -march=core2,
-march=core-avx2, etc. It seems that it's compiling the code in different
variants, which is OK.
The cflags specified by the .pc file are dubious: they add -I/usr/include/hs,
even though it would be better no to do that, and require users of the library
to use #include <hs/hs.h>. But that's an upstream issue / inelegance.
Package looks OK.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component