https://bugzilla.redhat.com/show_bug.cgi?id=1795469
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Flags| |fedora-review+
--- Comment #3 from Fabio Valentini <decathorpe(a)gmail.com> ---
Manual review below (with dependent packages built and installed in mock
manually):
- License is correct and permissible
- Package builds and installs correctly
- Package conforms to (Java) Packaging Guidelines
- Patches are documented and justified
- rpmlint shows no issues
================
Package APPROVED
================
Non-blocking suggestion:
I'm pretty sure BR: maven-source-plugin is not actually necessary since the
build doesn't produce source JARs.
You should be able to remove the BR from the build, as well (with
%pom_remove_plugin :maven-source-plugin").
It's not strictly necessary to do that, but it makes your package's dependency
tree smaller and probably makes mock/koji builds marginally faster.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component