https://bugzilla.redhat.com/show_bug.cgi?id=1944764
Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |CLOSED
CC| |zebob.m(a)gmail.com
Resolution|--- |WONTFIX
Doc Type|--- |If docs needed, set a value
Last Closed| |2021-04-02 16:56:50
--- Comment #1 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> ---
I am not sure of the legality of the provided roms. They seem to have been
extracted from GameBoys, as such the copyright should be held by Nintendo. See
https://gbdev.gg8.se/files/roms/bootroms/
See:
https://fedoraproject.org/wiki/Licensing:SoftwareTypes?rd=Licensing/Softw...
:
Emulators which depend on firmware or ROM files to function may not be included
in Fedora, unless the copyright holder(s) for the firmware/ROM files give clear
permission for the firmware/ROM files to be distributed (either under a Fedora
permissible license or under the Fedora firmware exception criteria). Note:
This only covers the situation where an emulator will not run at all without
firmware/ROM files. For example, emulators that compile and run, but ship with
no game ROMs are not covered by this rule.
The following review is for educational purpose only:
- Please don't use macro prefixed by two underscore, they are reserved for RPM
private use:
%{__mkdir_p} → mkdir -p
- You need to verify the %{_datadir}/applications/sameboy.desktop file. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_...
desktop-file-validate %{buildroot}/%{_datadir}/applications/sameboy.desktop
- I would rename the name and spec filename to sameboy all lowercase
- You need to own %{_datadir}/%{name}
%dir %{_datadir}/%{name}
and %{_datadir}/%{name}/Shaders
%dir %{_datadir}/%{name}/Shaders
(But you can just include the whole %{_datadir}/%{name} instead of listing all
files under that directory).
- You need to be more specific than this:
%{_datadir}/icons/hicolor/
→
%{_datadir}/icons/hicolor/*/apps/*.png
And then Requires: hicolor-icon-theme to own the icons directories.
- Use a more explicit name for your archive:
Source0:
https://github.com/LIJI32/SameBoy/archive/v%{version}/%{name}-%{version}....
But as I said it is not possible to package this in Fedora as the ROM are
non-free. Try proposing them to RPMFusion non-free repos.
I also think this shouldn't be in COPR
https://copr.fedorainfracloud.org/coprs/sentry/sameboy/ as it is non-free
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component