https://bugzilla.redhat.com/show_bug.cgi?id=1659833
--- Comment #4 from Fabio Valentini <decathorpe(a)gmail.com> ---
(In reply to Neal Gompa from comment #3)
(In reply to Fabio Valentini from comment #2)
> 1) You can use %{pypi_source} for the value of the Source0: tag.
>
I'm not a fan of those types of URL pre-fillers, so I avoided it.
I usually agree, but the pypi source tag is really nice.
But it's your decision if you want to use it or not.
> 2) Please fix the description - right now, it's a truncated,
ill-formatted,
> plain-text version of the rST README file.
>
Working on it.
Thanks!
> 3) LICENSE and docs/license.rst contain the same text, you can
drop the
> second one from the %files section.
>
> 4) Have you opened a bug against python-dbus regarding the missing provides?
>
I may file a pull request to fix it, since dbus-python is built properly in
Mageia.
+1
> 5) There's a small test suite shipped with the package, did
you try running
> it?
>
I did not because I don't know what satisfies "from gi.repository import
GdkPixbuf" used in the tests. It didn't work when I tried it in mock...
It's provided by python3-gobject-base, but I assume you'd also need to have
gtk3 installed for it to actually work.
$ sudo dnf provides
/usr/lib64/python3.7/site-packages/gi/overrides/GdkPixbuf.py
(...)
python3-gobject-base-3.30.4-1.fc29.x86_64 : Python 3 bindings for GObject
: Introspection base package
Repo : updates
Matched from:
Filename : /usr/lib64/python3.7/site-packages/gi/overrides/GdkPixbuf.py
(...)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component