https://bugzilla.redhat.com/show_bug.cgi?id=2126348
Jitka Plesnikova <jplesnik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review?
Assignee|nobody(a)fedoraproject.org |jplesnik(a)redhat.com
CC| |jplesnik(a)redhat.com
--- Comment #1 from Jitka Plesnikova <jplesnik(a)redhat.com> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires
FIX: Please add build-requires:
perl(base) - lib/Tickit/Pen.pm:356
perl(Carp) - lib/Tickit.pm:11
perl(Config) - spec file:54
perl(constant) - lib/Tickit/Pen.pm:357
perl(Errno) - t/30tickit.t:16
perl(integer) - lib/Tickit/Utils.pm:277
perl(IO::Handle) - lib/Tickit.pm:13
perl(List::Util) - lib/Tickit/RectSet.pm:11
perl(overload) - lib/Tickit/Pen.pm:345
perl(POSIX) - t/03utils.t:8
perl(Scalar::Util) - lib/Tickit.pm:15
perl(Test::Builder) - lib/Tickit/Test.pm:54
perl(Time::HiRes) - lib/Tickit.pm:16
perl(utf8) - t/03utils.t:23
perl(XSLoader) - lib/Tickit.pm:19
$ rpm -qp --requires perl-Tickit-0.73-1.fc38.x86_64.rpm | sort | uniq -c | grep
-v rpmlib
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 libc.so.6(GLIBC_2.7)(64bit)
1 libtickit.so.3()(64bit)
1 perl(base)
1 perl(Carp)
1 perl(constant)
1 perl(Exporter)
1 perl(IO::Handle)
1 perl(List::Util)
1 perl(:MODULE_COMPAT_5.36.0)
1 perl(overload)
1 perl(Scalar::Util)
1 perl(Struct::Dumb) >= 0.04
1 perl(Test::Builder)
1 perl(Tickit)
1 perl(Tickit::Debug)
1 perl(Tickit::Event)
1 perl(Tickit::Pen) >= 0.31
1 perl(Tickit::Rect)
1 perl(Tickit::RectSet)
1 perl(Tickit::RenderBuffer)
1 perl(Tickit::Term)
1 perl(Tickit::Test::MockTerm)
1 perl(Tickit::Utils)
1 perl(Tickit::Window)
1 perl(Time::HiRes)
1 perl(:VERSION) >= 5.14.0
1 perl(warnings)
1 rtld(GNU_HASH)
FIX: Please add run-requires:
perl(XSLoader) - lib/Tickit.pm:19
$ rpm -qp --requires perl-Tickit-tests-0.73-1.fc38.x86_64.rpm | sort | uniq -c
| grep -v rpmlib
1 perl(Errno)
1 perl(IO::Handle)
1 perl(POSIX)
1 perl(Test::Builder::Tester)
2 perl(Test::Fatal)
1 perl(Test::Harness)
1 perl(Test::HexString)
1 perl(Test::More)
1 perl(Test::Refcount)
1 perl(Tickit)
1 perl-Tickit = 0.73-1.fc38
1 perl(Tickit::Pen)
1 perl(Tickit::Rect)
1 perl(Tickit::RectSet)
1 perl(Tickit::RenderBuffer)
1 perl(Tickit::StringPos)
1 perl(Tickit::Term)
1 perl(Tickit::Test)
1 perl(Tickit::Utils)
1 perl(Tickit::Window)
1 perl(Time::HiRes)
1 perl(utf8)
1 perl(:VERSION) >= 5.14.0
1 perl(warnings)
1 /usr/bin/perl
1 /usr/bin/sh
FIX: Please remove duplicated run-require 'perl(Test::Fatal)'
FIX: Please add run-requires 'perl(constant)'
$ rpm -qp --provides perl-Tickit-0.73-1.fc38.x86_64.rpm | sort | uniq -c
1 perl(Tickit) = 0.73
1 perl-Tickit = 0.73-1.fc38
1 perl(Tickit::Debug) = 0.73
1 perl(Tickit::Event) = 0.73
1 perl(Tickit::Pen) = 0.73
1 perl(Tickit::Pen::Immutable) = 0.73
1 perl(Tickit::Pen::Mutable) = 0.73
1 perl(Tickit::Rect) = 0.73
1 perl(Tickit::RectSet) = 0.73
1 perl(Tickit::RenderBuffer) = 0.73
1 perl(Tickit::StringPos) = 0.73
1 perl(Tickit::Term) = 0.73
1 perl(Tickit::Test) = 0.73
1 perl(Tickit::Test::MockTerm) = 0.73
1 perl(Tickit::Utils) = 0.73
1 perl(Tickit::Window) = 0.73
1 perl-Tickit(x86-64) = 0.73-1.fc38
$ rpm -qp --provides perl-Tickit-tests-0.73-1.fc38.x86_64.rpm | sort | uniq -c
1 perl-Tickit-tests = 0.73-1.fc38
1 perl-Tickit-tests(x86-64) = 0.73-1.fc38
Binary provides are Ok.
$ rpmlint ./perl-Tickit*
Rpmlint is ok
FIX: In section %files,
- please move LICENSE from %docs to %license
- please remove META.json, it is only metadata - not useful
FIX: The t/99pod.t has to be removed from perl-Tickit-tests. Test::Pod check
works only for lib/ in the repository.
t/99pod.t ................. 1/1
# Failed test 'POD test for lib'
# at /usr/share/perl5/vendor_perl/Test/Pod.pm line 184.
# lib does not exist
# Looks like you failed 1 test of 1.
t/99pod.t ................. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests
Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items and provide a new spec file.
Resolution:
NOT Approved
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2126348