https://bugzilla.redhat.com/show_bug.cgi?id=1980723
--- Comment #9 from Neal Gompa <ngompa13(a)gmail.com> ---
(In reply to Ben Kircher from comment #8)
Hey, thanks for reviewing!
> * Why do we "BuildRequires: systemd"? Generally pulling in systemd itself
isn't needed.
Fixed.
> * You're not following the guidelines for systemd units
Fixed this. Hope this looks good now.
> * Why was the shared library removed? The problem with it is that it needs a soname
configured in CMake so that some kind of API/ABI stability promise exists. Without the
shared library, the headers are not very useful, since there's nothing to link to.
True.
Puhh, OK, this is about the plugins. From what I can see: The unversioned
shared library is used by plugins. The fluent-bit binary itself does not
link against the shared library.
Plugins are loaded with dlopen(3)/dlsym(3) by the fluent-bit binary itself.
There is also support for writing plugins in Go when -DFLB_PROXY_GO=On is
set (which we don't here). Those Go plugins probably need that shared
library, too.
I'm not really interested in writing plugins or using any. So if possible I
would drop the devel package (not sure this is OK with packaging guidelines?)
At the same time I would open an issue in upstream GH and ask friendly for a
set_target_properties(SOVERSION …) to be added to their CMake files. At the
same time for those header files all to be put under under a common
fluent-bit directory. As soon this is done, I could add a devel package.
What do you think?
That's fine with me.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1980723