https://bugzilla.redhat.com/show_bug.cgi?id=1958895
--- Comment #1 from Karolina Surma <ksurma(a)redhat.com> ---
Hi Ankur,
I have a few remarks regarding the package.
- Tests
If there are tests in the upstream, they should be run in the build process.
As they're not present in PyPI tarball, it'd be better to use the archive from
GitHub as Source.
Then %bcond_with can be removed entirely.
Tests should be run using %pytest macro.
- Extras
The package in the upstream provides extras: asyncio, curio and trio.
python-socks[asyncio] is required by the blocked python-aiohttp-socks so at
least this one should be provided.
Please refer to this site for details how to define extras:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_python...
- Nitpicks
1) Consider removing name macros:
%global modname socks
%global pypi_name python-%{modname}
%global undername python_%{modname}
They make the spec file less readable. It'd be nicer to copy&paste URL
directly.
'modname' doesn't mean module name, so if you decide to keep them, it'd
be
better to rename to something like 'basename'.
2) There is a section in prep commented out - if it's not used, it should be
removed.
# Comment out to remove /usr/bin/env shebangs
# Can use something similar to correct/remove /usr/bin/python shebangs also
# find . -type f -name "*.py" -exec sed -i '/^#![ ]*\/usr\/bin\/env.*$/
d' {}
2>/dev/null ';'
I'll continue with the full review on the updated files.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component