https://bugzilla.redhat.com/show_bug.cgi?id=1671571
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |decathorpe(a)gmail.com
--- Comment #5 from Fabio Valentini <decathorpe(a)gmail.com> ---
Just some small comments from a Packaging Committee member:
- Please don't include static libraries, unless *absolutely necessary*.
In this case, I think it can be safely removed (probably by rm-ing it from the
buildroot at the end of %install):
rm %{buildroot}/%{_libdir}/lib%{name}.a
See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-stat...
- "gobject-introspection-devel" could be replaced by
"pkgconfig(gobject-introspection-1.0)"
Mainly for consistency, since you're already using pkgconfig(foo) BuildRequires
for other things.
- Depending on the size of the html docs, they should be moved to a separate,
(probably noarch) -doc sub-package.
For example, fedora-review recommends to move documentation to a separate
sub-package if it's bigger than 1 MB.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component